[PyTorch] Reference to c10::GetCPUAllocator() directly #49068
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TH folder has some kernal implementations referenced by ATen/native. It goes with ATen/native in the follow-up diff for per-app selective build. ATen/Context.cpp stays in the lib level and should not reference to symbols in TH directly. It's a simple change in this diff, as ```getTHDefaultAllocator()``` did nothing but returns ```c10::GetCPUAllocator()```. Use ```c10::GetCPUAllocator()``` instead of going extra route through ```getTHDefaultAllocator()```. Differential Revision: [D24147914](https://our.internmc.facebook.com/intern/diff/D24147914/) [ghstack-poisoned]
iseeyuan
added a commit
that referenced
this pull request
Dec 9, 2020
TH folder has some kernal implementations referenced by ATen/native. It goes with ATen/native in the follow-up diff for per-app selective build. ATen/Context.cpp stays in the lib level and should not reference to symbols in TH directly. It's a simple change in this diff, as ```getTHDefaultAllocator()``` did nothing but returns ```c10::GetCPUAllocator()```. Use ```c10::GetCPUAllocator()``` instead of going extra route through ```getTHDefaultAllocator()```. Differential Revision: [D24147914](https://our.internmc.facebook.com/intern/diff/D24147914/) ghstack-source-id: 118151905 Pull Request resolved: #49068
Codecov Report
@@ Coverage Diff @@
## gh/iseeyuan/105/base #49068 +/- ##
=====================================================
Coverage 80.73% 80.73%
=====================================================
Files 1871 1871
Lines 201759 201759
=====================================================
+ Hits 162888 162892 +4
+ Misses 38871 38867 -4 |
|
This pull request has been merged in 41fd51d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
TH folder has some kernal implementations referenced by ATen/native. It goes with ATen/native in the follow-up diff for per-app selective build. ATen/Context.cpp stays in the lib level and should not reference to symbols in TH directly.
It's a simple change in this diff, as
getTHDefaultAllocator()did nothing but returnsc10::GetCPUAllocator(). Usec10::GetCPUAllocator()instead of going extra route throughgetTHDefaultAllocator().Differential Revision: D24147914