[package] implicitly extern stdlib before mocking #49306
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to mock out everything except for specific patterns while still correctly externing the python standard library. This makes it less likely that you will need to override require_module. [ghstack-poisoned]
suo
approved these changes
Dec 18, 2020
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 6, 2021
Summary: Pull Request resolved: pytorch#49306 This allows you to mock out everything except for specific patterns while still correctly externing the python standard library. This makes it less likely that you will need to override require_module. Test Plan: Imported from OSS Reviewed By: suo Differential Revision: D25526212 Pulled By: zdevito fbshipit-source-id: 7339f4c7f12af883496f79de95e57d452bb32dc2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This allows you to mock out everything except for specific patterns while
still correctly externing the python standard library. This makes it less
likely that you will need to override require_module.
Differential Revision: D25526212