Skip to content

Conversation

huiguoo
Copy link
Contributor

@huiguoo huiguoo commented Dec 17, 2020

Stack from ghstack:

Differential Revision: D25608804

…ed a test case for torch.fx.len()

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 17, 2020

💊 CI failures summary and remediations

As of commit 400e92e (more details on the Dr. CI page):


  • 1/2 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)
  • 1/2 broken upstream at merge base ede0b16 from Dec 16 until Dec 17

1 job timed out:

  • pytorch_linux_bionic_py3_8_gcc9_coverage_test2

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 20 times.

huiguoo added a commit that referenced this pull request Dec 17, 2020
…ed a test case for torch.fx.len()

ghstack-source-id: b6a0c32
Pull Request resolved: #49532
@huiguoo huiguoo requested a review from jamesr66a December 17, 2020 06:10
Copy link
Collaborator

@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Some small stuff then I think this should be good to go

… len(); added a test case for torch.fx.len()"

Differential Revision: [D25608804](https://our.internmc.facebook.com/intern/diff/D25608804)

[ghstack-poisoned]
… len(); added a test case for torch.fx.len()"

Differential Revision: [D25608804](https://our.internmc.facebook.com/intern/diff/D25608804)

[ghstack-poisoned]
huiguoo added a commit that referenced this pull request Dec 17, 2020
…ed a test case for torch.fx.len()

ghstack-source-id: d47ff96
Pull Request resolved: #49532
Copy link
Collaborator

@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! This is good to land after addressing the line-too-long error as well as I had one small comment

… len(); added a test case for torch.fx.len()"

Differential Revision: [D25608804](https://our.internmc.facebook.com/intern/diff/D25608804)

[ghstack-poisoned]
… len(); added a test case for torch.fx.len()"

Differential Revision: [D25608804](https://our.internmc.facebook.com/intern/diff/D25608804)

[ghstack-poisoned]
… len(); added a test case for torch.fx.len()"

Differential Revision: [D25608804](https://our.internmc.facebook.com/intern/diff/D25608804)

[ghstack-poisoned]
huiguoo added a commit that referenced this pull request Dec 17, 2020
…ed a test case for torch.fx.len()

ghstack-source-id: b4cc4c3
Pull Request resolved: #49532
@facebook-github-bot
Copy link
Contributor

@huiguoo merged this pull request in e2e44bb.

@facebook-github-bot facebook-github-bot deleted the gh/huiguoo/6/head branch December 22, 2020 15:17
hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 6, 2021
…(); added a test case for torch.fx.len() (pytorch#49532)

Summary: Pull Request resolved: pytorch#49532

Test Plan: Imported from OSS

Reviewed By: jamesr66a

Differential Revision: D25608804

Pulled By: huiguoo

fbshipit-source-id: 93ac02ab57db5d200d92443062286c34782ec0ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants