-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[Issue #46210] added torch.fx.len() to provide support for len(); added a test case for torch.fx.len() #49532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ed a test case for torch.fx.len() [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 400e92e (more details on the Dr. CI page):
1 job timed out:
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Some small stuff then I think this should be good to go
… len(); added a test case for torch.fx.len()" Differential Revision: [D25608804](https://our.internmc.facebook.com/intern/diff/D25608804) [ghstack-poisoned]
… len(); added a test case for torch.fx.len()" Differential Revision: [D25608804](https://our.internmc.facebook.com/intern/diff/D25608804) [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! This is good to land after addressing the line-too-long error as well as I had one small comment
… len(); added a test case for torch.fx.len()" Differential Revision: [D25608804](https://our.internmc.facebook.com/intern/diff/D25608804) [ghstack-poisoned]
… len(); added a test case for torch.fx.len()" Differential Revision: [D25608804](https://our.internmc.facebook.com/intern/diff/D25608804) [ghstack-poisoned]
… len(); added a test case for torch.fx.len()" Differential Revision: [D25608804](https://our.internmc.facebook.com/intern/diff/D25608804) [ghstack-poisoned]
…(); added a test case for torch.fx.len() (pytorch#49532) Summary: Pull Request resolved: pytorch#49532 Test Plan: Imported from OSS Reviewed By: jamesr66a Differential Revision: D25608804 Pulled By: huiguoo fbshipit-source-id: 93ac02ab57db5d200d92443062286c34782ec0ef
Stack from ghstack:
Differential Revision: D25608804