Skip to content

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Dec 20, 2020

Used to temporarily change working directory, but restore it even if exception is raised
Use it in test_type_hints and during code coverage collection

@malfet malfet requested review from a team and ezyang December 20, 2020 16:44
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 20, 2020

💊 CI failures summary and remediations

As of commit 5b7b5ab (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 14 times.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@malfet malfet force-pushed the malfet/add-set-cwd branch from 5f28a5e to abb721d Compare December 21, 2020 17:00
Used to temporarily change working directory, but restore it even if exception is raised
Use it in test_type_hints and during code coverage collection
@malfet malfet force-pushed the malfet/add-set-cwd branch from abb721d to 5b7b5ab Compare December 21, 2020 17:01
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@malfet malfet deleted the malfet/add-set-cwd branch December 21, 2020 21:07
@facebook-github-bot
Copy link
Contributor

@malfet merged this pull request in 12942ea.

hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 6, 2021
Summary:
Used to temporarily change working directory, but restore it even if exception is raised
Use it in test_type_hints and during code coverage collection

Pull Request resolved: pytorch#49657

Reviewed By: walterddr

Differential Revision: D25660543

Pulled By: malfet

fbshipit-source-id: 77f08d57e4b60b95daa4068d0dacf7c25f978526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants