Clean up some type annotations in torch/testing/_internal #50078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-barnes
requested review from
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit 801f15b (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 20 times. |
facebook-github-bot
added
cla signed
oncall: jit
|
This pull request was exported from Phabricator. Differential Revision: D25717560 |
pritamdamania87
approved these changes
Jan 5, 2021
|
This pull request was exported from Phabricator. Differential Revision: D25717560 |
r-barnes
force-pushed
the
export-D25717560
branch
from
1357ec5 to
53df768
Compare
) Summary: Pull Request resolved: pytorch#50078 Upgrades type annotations from Python2 to Python3 Test Plan: Sandcastle tests Reviewed By: pritamdamania87 Differential Revision: D25717560 fbshipit-source-id: f77f055d777c3793ca5ef0ab2dd8126720f6afa6
|
This pull request was exported from Phabricator. Differential Revision: D25717560 |
r-barnes
force-pushed
the
export-D25717560
branch
from
53df768 to
801f15b
Compare
Codecov Report
@@ Coverage Diff @@
## master #50078 +/- ##
==========================================
+ Coverage 80.48% 80.52% +0.04%
==========================================
Files 1900 1900
Lines 206210 206212 +2
==========================================
+ Hits 165973 166062 +89
+ Misses 40237 40150 -87 |
|
This pull request has been merged in efe0533. |
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 14, 2021
) Summary: Pull Request resolved: pytorch#50078 Upgrades type annotations from Python2 to Python3 Test Plan: Sandcastle tests Reviewed By: pritamdamania87 Differential Revision: D25717560 fbshipit-source-id: cec631f3121ef9ab87ff8b3b00f1fae6df9a2155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Upgrades type annotations from Python2 to Python3
Test Plan: Sandcastle tests
Differential Revision: D25717560