Skip to content

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Jan 6, 2021

Stack from ghstack:

There are currently 17 types, so this used to stretch across 3 cache lines and now it fits in one. All the types in question seem to be way under 255 bytes in size anyway.

Differential Revision: D25813574

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

There are currently 17 types, so this used to stretch across 3 cache lines and now it fits in one. All the types in question seem to be way under 255 bytes in size anyway.

Differential Revision: [D25813574](https://our.internmc.facebook.com/intern/diff/D25813574/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25813574/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 6, 2021

💊 CI failures summary and remediations

As of commit 00f72f2 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 4 times.

swolchok added a commit that referenced this pull request Jan 6, 2021
There are currently 17 types, so this used to stretch across 3 cache lines and now it fits in one. All the types in question seem to be way under 255 bytes in size anyway.

Differential Revision: [D25813574](https://our.internmc.facebook.com/intern/diff/D25813574/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25813574/)!

ghstack-source-id: 119485090
Pull Request resolved: #50165
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #50165 (00f72f2) into gh/swolchok/64/base (ad7d208) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##           gh/swolchok/64/base   #50165      +/-   ##
=======================================================
- Coverage                80.68%   80.67%   -0.01%     
=======================================================
  Files                     1900     1900              
  Lines                   206246   206246              
=======================================================
- Hits                    166407   166399       -8     
- Misses                   39839    39847       +8     

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 160b4be.

@facebook-github-bot facebook-github-bot deleted the gh/swolchok/64/head branch January 11, 2021 15:17
hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 14, 2021
Summary:
Pull Request resolved: pytorch#50165

There are currently 17 types, so this used to stretch across 3 cache lines and now it fits in one. All the types in question seem to be way under 255 bytes in size anyway.
ghstack-source-id: 119485090

Test Plan: CI, profiled internal benchmarks

Reviewed By: smessmer

Differential Revision: D25813574

fbshipit-source-id: c342d4f12a7b035503e1483b8301f68d98f3c503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants