[TensorExpr] Move 'initializer' field from 'Tensor' to 'Buf'. #50993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step to make 'Tensor` a thin wrapper over 'Buf' and 'Stmt', which will be finished in subsequent PRs. This change also allows to remove 'buf_initializers_' from 'LoopNest', making it "less stateful". [ghstack-poisoned]
facebook-github-bot
added
cla signed
oncall: jit
💊 CI failures summary and remediationsAs of commit 41c2d18 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jan 23, 2021
ZolotukhinM
requested review from
bertmaher,
navahgar and
nickgg
and removed request for
nickgg
Codecov Report
@@ Coverage Diff @@
## gh/ZolotukhinM/395/base #50993 +/- ##
===========================================================
- Coverage 80.88% 80.88% -0.01%
===========================================================
Files 1929 1929
Lines 210526 210522 -4
===========================================================
- Hits 170292 170286 -6
- Misses 40234 40236 +2 |
bertmaher
approved these changes
Jan 26, 2021
added 2 commits
January 26, 2021 17:33
…f'." This is the first step to make 'Tensor` a thin wrapper over 'Buf' and 'Stmt', which will be finished in subsequent PRs. This change also allows to remove 'buf_initializers_' from 'LoopNest', making it "less stateful". Differential Revision: [D26038224](https://our.internmc.facebook.com/intern/diff/D26038224) [ghstack-poisoned]
…f'." This is the first step to make 'Tensor` a thin wrapper over 'Buf' and 'Stmt', which will be finished in subsequent PRs. This change also allows to remove 'buf_initializers_' from 'LoopNest', making it "less stateful". Differential Revision: [D26038224](https://our.internmc.facebook.com/intern/diff/D26038224) [ghstack-poisoned]
|
@ZolotukhinM merged this pull request in 42aeb68. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Tensorclass. #50995 [TensorExpr] RedesignTensorclass.This is the first step to make 'Tensor` a thin wrapper over 'Buf' and
'Stmt', which will be finished in subsequent PRs. This change also
allows to remove 'buf_initializers_' from 'LoopNest', making it "less
stateful".
Differential Revision: D26038224