[PyTorch] Devirtualize TensorImpl::has_storage #51049
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff makes it OK to query has_storage() on all TensorImpls. I added debug assertions that storage_ is indeed never set on them, which is required for this to be correct. Differential Revision: [D26008498](https://our.internmc.facebook.com/intern/diff/D26008498/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 306e9c3 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jan 25, 2021
This diff makes it OK to query has_storage() on all TensorImpls. I added debug assertions that storage_ is indeed never set on them, which is required for this to be correct. Differential Revision: [D26008498](https://our.internmc.facebook.com/intern/diff/D26008498/) [ghstack-poisoned]
ezyang
approved these changes
Jan 27, 2021
@ezyang is straight deletion an option? That would certainly leave things in a much simpler state, but do existing callsites all vanish cleanly? |
I think callers can just call |
This diff makes it OK to query has_storage() on all TensorImpls. I added debug assertions that storage_ is indeed never set on them, which is required for this to be correct. Differential Revision: [D26008498](https://our.internmc.facebook.com/intern/diff/D26008498/) [ghstack-poisoned]
This diff makes it OK to query has_storage() on all TensorImpls. I added debug assertions that storage_ is indeed never set on them, which is required for this to be correct. Differential Revision: [D26008498](https://our.internmc.facebook.com/intern/diff/D26008498/) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/swolchok/86/base #51049 +/- ##
====================================================
Coverage 80.86% 80.86%
====================================================
Files 1938 1938
Lines 211184 211176 -8
====================================================
+ Hits 170764 170766 +2
+ Misses 40420 40410 -10 |
|
This pull request has been merged in 6c24296. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This diff makes it OK to query has_storage() on all TensorImpls. I added debug assertions that storage_ is indeed never set on them, which is required for this to be correct.
Differential Revision: D26008498