Remove debug-only assertion from vulkan::api::Command::Command as the buffer can legitimately be null. #51160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… buffer can legitimately be null. [ghstack-poisoned]
This was referenced Jan 27, 2021
💊 CI failures summary and remediationsAs of commit 7d31234 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
SS-JIA
approved these changes
Jan 27, 2021
…mand as the buffer can legitimately be null." Differential Revision: [D26131252](https://our.internmc.facebook.com/intern/diff/D26131252) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/AshkanAliabadi/79/base #51160 +/- ##
==========================================================
Coverage 80.84% 80.84%
==========================================================
Files 1931 1931
Lines 210879 210879
==========================================================
+ Hits 170484 170489 +5
+ Misses 40395 40390 -5 |
|
@AshkanAliabadi merged this pull request in 8a8fac6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D26131252