Skip to content

Conversation

jamesr66a
Copy link
Collaborator

@jamesr66a jamesr66a commented Jan 30, 2021

Stack from ghstack:

Differential Revision: D26161172

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 30, 2021

💊 CI failures summary and remediations

As of commit 6bcdeab (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

1 failure not recognized by patterns:

Job Step Action
CircleCI pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 Run tests 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

jamesr66a pushed a commit that referenced this pull request Jan 30, 2021
ghstack-source-id: 9364226
Pull Request resolved: #51392
jamesr66a pushed a commit that referenced this pull request Jan 30, 2021
Pull Request resolved: #51392

Differential Revision: [D26161172](https://our.internmc.facebook.com/intern/diff/D26161172/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D26161172/)!
ghstack-source-id: 120720724
@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #51392 (747b182) into gh/jamesr66a/356/base (662b6d2) will decrease coverage by 0.34%.
The diff coverage is 66.66%.

@@                    Coverage Diff                    @@
##           gh/jamesr66a/356/base   #51392      +/-   ##
=========================================================
- Coverage                  80.86%   80.52%   -0.35%     
=========================================================
  Files                       1938     1938              
  Lines                     211190   211190              
=========================================================
- Hits                      170772   170052     -720     
- Misses                     40418    41138     +720     

Copy link
Collaborator

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jamesr66a pushed a commit that referenced this pull request Feb 1, 2021
Pull Request resolved: #51392

Differential Revision: [D26161172](https://our.internmc.facebook.com/intern/diff/D26161172/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D26161172/)!
ghstack-source-id: bafc119
@facebook-github-bot
Copy link
Contributor

@jamesr66a merged this pull request in a1c5eba.

@facebook-github-bot facebook-github-bot deleted the gh/jamesr66a/356/head branch February 5, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants