Skip to content

add git submodule troubleshoot to CONTRIBUTING.md #51458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

add git submodule troubleshoot to CONTRIBUTING.md #51458

wants to merge 3 commits into from

Conversation

walterddr
Copy link
Contributor

Fixes #51355.

janeyx99
janeyx99 approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@janeyx99
Copy link
Contributor

janeyx99 commented Feb 1, 2021 •
edited
Loading

This may not be relevant to this PR, but when I remove the submodule.recurse from my global git config, I get errors when running python setup.py develop:

Repro:

  1. Remove submodule.recurse = true
  2. Run git submodule update --init --recursive
  3. Try python setup.py develop
  4. Get this error:

Building wheel torch-1.8.0a0+Unknown
-- Building version 1.8.0a0+Unknown
Could not find /data/users/janeyx/pytorch-debug/third_party/onnx/CMakeLists.txt
Did you run 'git submodule update --init --recursive'?

  1. Try steps 2 and 3 again and get the same error in 4.

After going into third_party/onnx and running git checkout and git submodule update --init --recursive, I get a similar error for third_party/fbgemm. After resolving that, I am able to kick off a build.

UPDATE: the build fails because it cannot find a cmake file in protobuf, which I fix again by going into third_party/protobuf and updating it.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 1, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit a6cb047 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job Step Action
CircleCI pytorch_linux_xenial_py3_6_gcc5_4_test Run tests 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

facebook-github-bot
facebook-github-bot reviewed Feb 1, 2021
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Feb 1, 2021
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Feb 1, 2021
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@walterddr merged this pull request in 718e4b1.

@samestep samestep mentioned this pull request Mar 30, 2021
Closed
facebook-github-bot pushed a commit that referenced this pull request Mar 31, 2021
@samestep @facebook-github-bot
Keep Markdown ToCs up to date (#54974)
a74b10d 
Summary:
This PR uses [markdown-toc](https://github.com/jonschlinkert/markdown-toc#cli) to [automatically update the table of contents for `README.md` and `CONTRIBUTING.md`](#54904 (comment)) in CI.

This keeps the same format already used in `README.md`. While it does slightly change the format for the ToC in `CONTRIBUTING.md`, the new format is actually just the same as the old format that was already being used prior to #51458.

Race condition with #54904.

Pull Request resolved: #54974

Test Plan: The new "Lint / toc" job in GitHub Actions [succeeds](https://github.com/pytorch/pytorch/pull/54974/checks?check_run_id=2238739005) on this PR, and [fails](https://github.com/pytorch/pytorch/pull/54976/checks?check_run_id=2238784022) on #54976 with an understandable error message.

Reviewed By: malfet

Differential Revision: D27468390

Pulled By: samestep

fbshipit-source-id: 14a73f42ed546d4310140b94ded14e099185d0e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@janeyx99 janeyx99 janeyx99 approved these changes

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Include instructions to cleanly remove third_party dep

3 participants

@walterddr @janeyx99 @facebook-github-bot