Skip to content

[RPC] Move confirmation future in rref context to jit future #51695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[RPC] Move confirmation future in rref context to jit future #51695

wants to merge 7 commits into from

Conversation

rohan-varma
Copy link
Contributor

@rohan-varma rohan-varma commented Feb 4, 2021 •
edited
Loading

Stack from ghstack:

As part of the plan to completely eliminate torch/csrc/utils/future.h,
we are converting this to JitFuture (c10::ivalue::Future).

Differential Revision: D26238873

@rohan-varma
[RPC] Move confirmation future in rref context to jit future
056b71f 
As part of the plan to completely eliminate torch/csrc/utils/future.h,
we are converting this to JitFuture (c10::ivalue::Future).

Differential Revision: [D26238873](https://our.internmc.facebook.com/intern/diff/D26238873/)

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added cla signed oncall: distributed Add this issue/PR to distributed oncall triage queue labels Feb 4, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 4, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 95c2130 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_bionic_py3_6_clang9_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Feb 13 06:20:30 [E request_callback_no_python.cpp:653] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Feb 13 06:20:30 At:
Feb 13 06:20:30   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize
Feb 13 06:20:30   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize
Feb 13 06:20:30 
Feb 13 06:20:30 [E request_callback_no_python.cpp:653] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future
Feb 13 06:20:30 
Feb 13 06:20:30 At:
Feb 13 06:20:30   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize
Feb 13 06:20:30   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize
Feb 13 06:20:30 
Feb 13 06:20:30 [E request_callback_no_python.cpp:653] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future
Feb 13 06:20:30 
Feb 13 06:20:30 At:
Feb 13 06:20:30   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize
Feb 13 06:20:30   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize
Feb 13 06:20:30 
Feb 13 06:20:31 ok (1.740s)
Feb 13 06:20:32   test_return_future_remote (__main__.ProcessGroupRpcTestWithSpawn) ... RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend.
Feb 13 06:20:32 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend.
Feb 13 06:20:32 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend.
Feb 13 06:20:32 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend.
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This was referenced Feb 4, 2021
Closed
Closed
Closed
@rohan-varma
Update on "[RPC] Move confirmation future in rref context to jit future"
f62f631 
As part of the plan to completely eliminate torch/csrc/utils/future.h,
we are converting this to JitFuture (c10::ivalue::Future).

Differential Revision: [D26238873](https://our.internmc.facebook.com/intern/diff/D26238873/)

[ghstack-poisoned]
@rohan-varma
Update on "[RPC] Move confirmation future in rref context to jit future"
63323a7 
As part of the plan to completely eliminate torch/csrc/utils/future.h,
we are converting this to JitFuture (c10::ivalue::Future).

Differential Revision: [D26238873](https://our.internmc.facebook.com/intern/diff/D26238873/)

[ghstack-poisoned]
@rohan-varma
Update on "[RPC] Move confirmation future in rref context to jit future"
300f3cf 
As part of the plan to completely eliminate torch/csrc/utils/future.h,
we are converting this to JitFuture (c10::ivalue::Future).

Differential Revision: [D26238873](https://our.internmc.facebook.com/intern/diff/D26238873/)

[ghstack-poisoned]
mrshenli
mrshenli approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this!

@rohan-varma
Update on "[RPC] Move confirmation future in rref context to jit future"
f82143f 
As part of the plan to completely eliminate torch/csrc/utils/future.h,
we are converting this to JitFuture (c10::ivalue::Future).

Differential Revision: [D26238873](https://our.internmc.facebook.com/intern/diff/D26238873/)

[ghstack-poisoned]
@rohan-varma
Update on "[RPC] Move confirmation future in rref context to jit future"
b8bb0ae 
As part of the plan to completely eliminate torch/csrc/utils/future.h,
we are converting this to JitFuture (c10::ivalue::Future).

Differential Revision: [D26238873](https://our.internmc.facebook.com/intern/diff/D26238873/)

[ghstack-poisoned]
@rohan-varma
Update on "[RPC] Move confirmation future in rref context to jit future"
95c2130 
As part of the plan to completely eliminate torch/csrc/utils/future.h,
we are converting this to JitFuture (c10::ivalue::Future).

Differential Revision: [D26238873](https://our.internmc.facebook.com/intern/diff/D26238873/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 87c0b6b.

@facebook-github-bot facebook-github-bot deleted the gh/rohan-varma/226/head branch February 17, 2021 15:16
xsacha pushed a commit to xsacha/pytorch that referenced this pull request Mar 31, 2021
@rohan-varma
[RPC] Move confirmation future in rref context to jit future (pytorch…
7c53325 
…#51695)

Summary:
Pull Request resolved: pytorch#51695

As part of the plan to completely eliminate torch/csrc/utils/future.h,
we are converting this to JitFuture (c10::ivalue::Future).
ghstack-source-id: 121695708

Test Plan: CI

Reviewed By: mrshenli

Differential Revision: D26238873

fbshipit-source-id: 92bad1a349964ce8a9a80e2d1cf68f293cbe411c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrshenli mrshenli mrshenli approved these changes

@mingzhe09088 mingzhe09088 Awaiting requested review from mingzhe09088

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@kiukchung kiukchung Awaiting requested review from kiukchung

Assignees

No one assigned

Labels

cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rohan-varma @facebook-github-bot @mrshenli