Explicitly define all DataTypes in python/core.py #51768
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This updates python/core.py to explicitly define all of the `DataType` values rather than dynamically defining them at runtime from the `caffe2_pb2` values. This allows type checkers like Pyre and Mypy to see the members of the `DataType` class. Otherwise the type checkers report errors such as `"core.DataType" has no attribute "INT64"`. This code does keep a run-time check that all of the data types defined by `caffe2_pb2.proto` are defined correctly in this file. This way if someone does add a new type to `caffe2_pb2.proto` it should be very quickly apparent that this file needs to be updated and kept in sync. Test Plan: Confirmed that various caffe2/python test still pass. Will check CI test results. [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 5e12bde (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Feb 5, 2021
Summary: This updates python/core.py to explicitly define all of the `DataType` values rather than dynamically defining them at runtime from the `caffe2_pb2` values. This allows type checkers like Pyre and Mypy to see the members of the `DataType` class. Otherwise the type checkers report errors such as `"core.DataType" has no attribute "INT64"`. This code does keep a run-time check that all of the data types defined by `caffe2_pb2.proto` are defined correctly in this file. This way if someone does add a new type to `caffe2_pb2.proto` it should be very quickly apparent that this file needs to be updated and kept in sync. Test Plan: Confirmed that various caffe2/python test still pass. Will check CI test results. Differential Revision: [D26271725](https://our.internmc.facebook.com/intern/diff/D26271725) [ghstack-poisoned]
simpkins
added a commit
that referenced
this pull request
Feb 11, 2021
Pull Request resolved: #51768 This updates python/core.py to explicitly define all of the `DataType` values rather than dynamically defining them at runtime from the `caffe2_pb2` values. This allows type checkers like Pyre and Mypy to see the members of the `DataType` class. Otherwise the type checkers report errors such as `"core.DataType" has no attribute "INT64"`. This code does keep a run-time check that all of the data types defined by `caffe2_pb2.proto` are defined correctly in this file. This way if someone does add a new type to `caffe2_pb2.proto` it should be very quickly apparent that this file needs to be updated and kept in sync. Differential Revision: [D26271725](https://our.internmc.facebook.com/intern/diff/D26271725/) ghstack-source-id: 121107704
Summary: This updates python/core.py to explicitly define all of the `DataType` values rather than dynamically defining them at runtime from the `caffe2_pb2` values. This allows type checkers like Pyre and Mypy to see the members of the `DataType` class. Otherwise the type checkers report errors such as `"core.DataType" has no attribute "INT64"`. This code does keep a run-time check that all of the data types defined by `caffe2_pb2.proto` are defined correctly in this file. This way if someone does add a new type to `caffe2_pb2.proto` it should be very quickly apparent that this file needs to be updated and kept in sync. Test Plan: Confirmed that various caffe2/python test still pass. Will check CI test results. Differential Revision: [D26271725](https://our.internmc.facebook.com/intern/diff/D26271725) [ghstack-poisoned]
simpkins
added a commit
that referenced
this pull request
Feb 18, 2021
Pull Request resolved: #51768 This updates python/core.py to explicitly define all of the `DataType` values rather than dynamically defining them at runtime from the `caffe2_pb2` values. This allows type checkers like Pyre and Mypy to see the members of the `DataType` class. Otherwise the type checkers report errors such as `"core.DataType" has no attribute "INT64"`. This code does keep a run-time check that all of the data types defined by `caffe2_pb2.proto` are defined correctly in this file. This way if someone does add a new type to `caffe2_pb2.proto` it should be very quickly apparent that this file needs to be updated and kept in sync. Differential Revision: [D26271725](https://our.internmc.facebook.com/intern/diff/D26271725/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D26271725/)! ghstack-source-id: 121936201
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
…1768) Summary: Pull Request resolved: pytorch#51768 This updates python/core.py to explicitly define all of the `DataType` values rather than dynamically defining them at runtime from the `caffe2_pb2` values. This allows type checkers like Pyre and Mypy to see the members of the `DataType` class. Otherwise the type checkers report errors such as `"core.DataType" has no attribute "INT64"`. This code does keep a run-time check that all of the data types defined by `caffe2_pb2.proto` are defined correctly in this file. This way if someone does add a new type to `caffe2_pb2.proto` it should be very quickly apparent that this file needs to be updated and kept in sync. ghstack-source-id: 121936201 Test Plan: Confirmed that various caffe2/python tests still pass. Verified that this allows many `pyre-fixme` comments to be removed in downstream projects, and that Pyre is still clean for these projects. Reviewed By: jeffdunn Differential Revision: D26271725 Pulled By: simpkins fbshipit-source-id: f9e95795de60aba67d7d3872d0c141ed82ba8e39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
This updates python/core.py to explicitly define all of the
DataTypevalues rather than dynamically defining them at runtime from the
caffe2_pb2values.This allows type checkers like Pyre and Mypy to see the members of the
DataTypeclass. Otherwise the type checkers report errors such as"core.DataType" has no attribute "INT64".This code does keep a run-time check that all of the data types defined
by
caffe2_pb2.protoare defined correctly in this file. This way ifsomeone does add a new type to
caffe2_pb2.protoit should be veryquickly apparent that this file needs to be updated and kept in sync.
Test Plan:
Confirmed that various caffe2/python test still pass. Will check CI
test results.
Differential Revision: D26271725