[WIP] Add a _flush_compilation_cache for testing
#52001
Conversation
facebook-github-bot
added
cla signed
oncall: jit
💊 CI failures summary and remediationsAs of commit 3217ed5 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Codecov Report
@@ Coverage Diff @@
## master #52001 +/- ##
==========================================
- Coverage 80.77% 80.77% -0.01%
==========================================
Files 1953 1953
Lines 214064 214072 +8
==========================================
+ Hits 172913 172918 +5
- Misses 41151 41154 +3 |
There was a problem hiding this comment.
@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| GraphExecutorState getDebugState() override; | ||
| ~ProfilingGraphExecutorImpl() override = default; | ||
|
|
||
| void flushCompilationCache() { |
There was a problem hiding this comment.
you might want to add some underscores here, or call it debugFlushCompilationCache. We dont want anyone else to use this really..
There was a problem hiding this comment.
I'll rename it to debug
|
|
||
| void flushCompilationCache() { | ||
| pr_.reset(); | ||
| fallback_plan_.reset(); |
There was a problem hiding this comment.
I think some of these have mutexes that you're not accessing
There was a problem hiding this comment.
Ah, yes! Thank you for pointing this out!
There was a problem hiding this comment.
@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@Krovatkin merged this pull request in 0019a20. |
Summary: Pull Request resolved: pytorch#52001 Reviewed By: eellison Differential Revision: D26371876 Pulled By: Krovatkin fbshipit-source-id: db773d7124916bad31e80bdd7bb9b4170060977b
3 participants
No description provided.