Fix compiler warning for MathConstants.h #52123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-barnes
force-pushed
the
export-D26379485
branch
from
64cf393 to
dba5620
Compare
Codecov Report
@@ Coverage Diff @@
## master #52123 +/- ##
==========================================
- Coverage 80.57% 80.57% -0.01%
==========================================
Files 1957 1957
Lines 214523 214525 +2
==========================================
- Hits 172852 172850 -2
- Misses 41671 41675 +4 |
r-barnes
force-pushed
the
export-D26379485
branch
4 times, most recently
from
6f91a5c to
d10c0e2
Compare
💊 CI failures summary and remediationsAs of commit 5b7e901 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
r-barnes
force-pushed
the
export-D26379485
branch
7 times, most recently
from
5202026 to
308e251
Compare
Summary:
Compiler currently complains:
```
caffe2/c10/util/MatchConstants.h(18): warning: calling a constexpr __host__ function("from_bits") from a __host__ __device__ function("pi") is not allowed.
```
This diff extirpates the warning
Test Plan: Sandcastle tests
Differential Revision: D26379485
fbshipit-source-id: 23afe2b0a5935966d4825892a3e134ba46168ad3
r-barnes
force-pushed
the
export-D26379485
branch
from
308e251 to
5b7e901
Compare
|
This pull request has been merged in f1e004b. |
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: Pull Request resolved: pytorch#52123 Compiler currently complains: ``` caffe2/c10/util/MatchConstants.h(18): warning: calling a constexpr __host__ function("from_bits") from a __host__ __device__ function("pi") is not allowed. ``` This diff extirpates the warning Test Plan: Sandcastle tests Reviewed By: xush6528 Differential Revision: D26379485 fbshipit-source-id: ab4821119cba8c43fd1d5788c4632d0613529ec8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Compiler currently complains:
Differential Revision: D26379485