[PyTorch] Add comment to unify macro and rename one macro #52573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 85a392c (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Codecov Report
@@ Coverage Diff @@
## gh/cccclai/25/base #52573 +/- ##
======================================================
- Coverage 80.76% 80.76% -0.01%
======================================================
Files 1969 1969
Lines 216037 216037
======================================================
- Hits 174490 174478 -12
- Misses 41547 41559 +12 |
iseeyuan
approved these changes
Feb 22, 2021
aocsa
pushed a commit
to Quansight/pytorch
that referenced
this pull request
Mar 15, 2021
) Summary: Pull Request resolved: pytorch#52573 ## Summary Address comments in pytorch#52540 1. Add a comment to indicate that the macros `BUILD_LITE_INTERPRETER` and `C10_MOBILE` will be unified. 2. Rename the macro `DBUILD_LITE_INTERPRETER` to `BUILD_LITE_INTERPRETER` ## Test plan 1. `MACOSX_DEPLOYMENT_TARGET=10.9 CC=clang CXX=clang++ USE_CUDA=0 DEBUG=1 MAX_JOBS=16 BUILD_LITE_INTERPRETER=1 python setup.py develop` 2. `/Users/chenlai/pytorch/cmake-build-debug/bin/test_lite_interpreter_runtime --gtest_filter=* --gtest_color=no` Test Plan: Imported from OSS Reviewed By: iseeyuan Differential Revision: D26572742 Pulled By: cccclai fbshipit-source-id: c8895fcfe8dd893f8157913f110e2ba025fc3955
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
) Summary: Pull Request resolved: pytorch#52573 ## Summary Address comments in pytorch#52540 1. Add a comment to indicate that the macros `BUILD_LITE_INTERPRETER` and `C10_MOBILE` will be unified. 2. Rename the macro `DBUILD_LITE_INTERPRETER` to `BUILD_LITE_INTERPRETER` ## Test plan 1. `MACOSX_DEPLOYMENT_TARGET=10.9 CC=clang CXX=clang++ USE_CUDA=0 DEBUG=1 MAX_JOBS=16 BUILD_LITE_INTERPRETER=1 python setup.py develop` 2. `/Users/chenlai/pytorch/cmake-build-debug/bin/test_lite_interpreter_runtime --gtest_filter=* --gtest_color=no` Test Plan: Imported from OSS Reviewed By: iseeyuan Differential Revision: D26572742 Pulled By: cccclai fbshipit-source-id: c8895fcfe8dd893f8157913f110e2ba025fc3955
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Address comments in #52540
BUILD_LITE_INTERPRETERandC10_MOBILEwill be unified.DBUILD_LITE_INTERPRETERtoBUILD_LITE_INTERPRETERTest plan
MACOSX_DEPLOYMENT_TARGET=10.9 CC=clang CXX=clang++ USE_CUDA=0 DEBUG=1 MAX_JOBS=16 BUILD_LITE_INTERPRETER=1 python setup.py develop/Users/chenlai/pytorch/cmake-build-debug/bin/test_lite_interpreter_runtime --gtest_filter=* --gtest_color=noStack from ghstack:
Differential Revision: D26572742