[ROCm] Enable test cases in test_data_parallel.py for ROCm #52708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Chen <kylechen@amd.com>
KyleCZH
requested review from
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
facebook-github-bot
added
cla signed
oncall: distributed
💊 CI failures summary and remediationsAs of commit b050868 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Codecov Report
@@ Coverage Diff @@
## master #52708 +/- ##
==========================================
- Coverage 80.80% 80.46% -0.35%
==========================================
Files 1972 1972
Lines 216282 216282
==========================================
- Hits 174775 174035 -740
- Misses 41507 42247 +740 |
ailzhang
added
the
triaged
mrshenli
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
…2708) Summary: Enabling the test cases because they are passing for ROCm. Signed-off-by: Kyle Chen <kylechen@amd.com> Pull Request resolved: pytorch#52708 Reviewed By: albanD Differential Revision: D26994458 Pulled By: mrshenli fbshipit-source-id: f0b3797c7889287a0154b1d5397df715ffb1c605
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling the test cases because they are passing for ROCm.
Signed-off-by: Kyle Chen kylechen@amd.com