Skip to content

[quant][graphmode][fx][fp16] Add fp16 support for sigmoid #52863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

[quant][graphmode][fx][fp16] Add fp16 support for sigmoid #52863

wants to merge 12 commits into from

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Feb 25, 2021 •
edited
Loading

Stack from ghstack:

Summary:

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_fixed_qparams_ops_fp16

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D26672273

@jerryzh168
[quant][graphmode][fx][fp16] Add fp16 support for sigmoid
ab910f6 
Summary:

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_fixed_qparams_ops_fp16

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 25, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit bbde551 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This was referenced Feb 25, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@jerryzh168 jerryzh168 requested a review from vkuzo February 26, 2021 17:44
@jerryzh168
Update on "[quant][graphmode][fx][fp16] Add fp16 support for sigmoid"
3c52903 
Summary:

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_fixed_qparams_ops_fp16

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D26672273](https://our.internmc.facebook.com/intern/diff/D26672273)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode][fx][fp16] Add fp16 support for sigmoid"
9feca98 
Summary:

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_fixed_qparams_ops_fp16

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D26672273](https://our.internmc.facebook.com/intern/diff/D26672273)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode][fx][fp16] Add fp16 support for sigmoid"
acf5971 
Summary:

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_fixed_qparams_ops_fp16

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D26672273](https://our.internmc.facebook.com/intern/diff/D26672273)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode][fx][fp16] Add fp16 support for sigmoid"
a741918 
Summary:

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_fixed_qparams_ops_fp16

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D26672273](https://our.internmc.facebook.com/intern/diff/D26672273)

[ghstack-poisoned]
vkuzo
vkuzo approved these changes Feb 27, 2021
View reviewed changes
torch/quantization/fx/quantization_patterns.py
Comment on lines +847 to +849
return quantizer.quantized_graph.node_copy(node, load_arg(quantized=False))
else:
return quantizer.quantized_graph.node_copy(node, load_arg(quantized=None))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for my own understanding, what's the difference between load_arg(quantized=False) and load_arg(quantized=None)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

load_arg(quantized=False) means dequantize the node if needed, load_arg(quantized=None) means do nothing, just copy the node

@jerryzh168
Update on "[quant][graphmode][fx][fp16] Add fp16 support for sigmoid"
f9f9339 
Summary:

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_fixed_qparams_ops_fp16

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D26672273](https://our.internmc.facebook.com/intern/diff/D26672273)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode][fx][fp16] Add fp16 support for sigmoid"
f8126c9 
Summary:

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_fixed_qparams_ops_fp16

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D26672273](https://our.internmc.facebook.com/intern/diff/D26672273)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode][fx][fp16] Add fp16 support for sigmoid"
0647e15 
Summary:

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_fixed_qparams_ops_fp16

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D26672273](https://our.internmc.facebook.com/intern/diff/D26672273)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode][fx][fp16] Add fp16 support for sigmoid"
23acfcf 
Summary:

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_fixed_qparams_ops_fp16

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D26672273](https://our.internmc.facebook.com/intern/diff/D26672273)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode][fx][fp16] Add fp16 support for sigmoid"
7ed8d7b 
Summary:

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_fixed_qparams_ops_fp16

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D26672273](https://our.internmc.facebook.com/intern/diff/D26672273)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode][fx][fp16] Add fp16 support for sigmoid"
27e1329 
Summary:

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_fixed_qparams_ops_fp16

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D26672273](https://our.internmc.facebook.com/intern/diff/D26672273)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode][fx][fp16] Add fp16 support for sigmoid"
bbde551 
Summary:

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_fixed_qparams_ops_fp16

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D26672273](https://our.internmc.facebook.com/intern/diff/D26672273)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d40b501.

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/561/head branch March 5, 2021 15:14
aocsa pushed a commit to Quansight/pytorch that referenced this pull request Mar 15, 2021
@jerryzh168 @aocsa
[quant][graphmode][fx][fp16] Add fp16 support for sigmoid (pytorch#52863
07f1508 
)

Summary: Pull Request resolved: pytorch#52863

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_fixed_qparams_ops_fp16

Imported from OSS

Reviewed By: vkuzo

Differential Revision: D26672273

fbshipit-source-id: 30d5befe2a24081ac12ac773df4d2bd26d2d0192
xsacha pushed a commit to xsacha/pytorch that referenced this pull request Mar 31, 2021
@jerryzh168
[quant][graphmode][fx][fp16] Add fp16 support for sigmoid (pytorch#52863
375c4a3 
)

Summary: Pull Request resolved: pytorch#52863

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_fixed_qparams_ops_fp16

Imported from OSS

Reviewed By: vkuzo

Differential Revision: D26672273

fbshipit-source-id: 30d5befe2a24081ac12ac773df4d2bd26d2d0192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuzo vkuzo vkuzo approved these changes

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jerryzh168 @facebook-github-bot @vkuzo