Skip to content

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Mar 4, 2021

Stack from ghstack:

Differential Revision: D26922419

…them in script mode. (#52748)

* Update tests for test_gru_* at this moment.

* Update flake8 error.

* Update tests for test_gru_* at this moment.

* Update flake8 error.

* Update test_gru_* test cases only.

* Fix flake8 issue.

* Fix flake8 issue on test.

* Still disable test cases created by make_test.

* Update code to fix issue 'AttributeError: 'RecursiveScriptModule' object has no attribute 'forward'' for test_elman_* test cases.

* Add script model support for test_lstm_* test cases.

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 4, 2021

💊 CI failures summary and remediations

As of commit 4fd29ad (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

…rt running them in script mode. (#52748)"

* Update tests for test_gru_* at this moment.

* Update flake8 error.

* Update tests for test_gru_* at this moment.

* Update flake8 error.

* Update test_gru_* test cases only.

* Fix flake8 issue.

* Fix flake8 issue on test.

* Still disable test cases created by make_test.

* Update code to fix issue 'AttributeError: 'RecursiveScriptModule' object has no attribute 'forward'' for test_elman_* test cases.

* Add script model support for test_lstm_* test cases.

[ghstack-poisoned]
…rt running them in script mode. (#52748)"

* Update tests for test_gru_* at this moment.

* Update flake8 error.

* Update tests for test_gru_* at this moment.

* Update flake8 error.

* Update test_gru_* test cases only.

* Fix flake8 issue.

* Fix flake8 issue on test.

* Still disable test cases created by make_test.

* Update code to fix issue 'AttributeError: 'RecursiveScriptModule' object has no attribute 'forward'' for test_elman_* test cases.

* Add script model support for test_lstm_* test cases.

[ghstack-poisoned]
…rt running them in script mode. (#52748)"

* Update tests for test_gru_* at this moment.

* Update flake8 error.

* Update tests for test_gru_* at this moment.

* Update flake8 error.

* Update test_gru_* test cases only.

* Fix flake8 issue.

* Fix flake8 issue on test.

* Still disable test cases created by make_test.

* Update code to fix issue 'AttributeError: 'RecursiveScriptModule' object has no attribute 'forward'' for test_elman_* test cases.

* Add script model support for test_lstm_* test cases.

[ghstack-poisoned]
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #53308 (4fd29ad) into gh/BowenBao/38/base (934e474) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##           gh/BowenBao/38/base   #53308      +/-   ##
=======================================================
- Coverage                77.55%   77.55%   -0.01%     
=======================================================
  Files                     1874     1874              
  Lines                   182979   182979              
=======================================================
- Hits                    141915   141907       -8     
- Misses                   41064    41072       +8     

@facebook-github-bot
Copy link
Contributor

@SplitInfinity merged this pull request in be344e9.

@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/38/head branch March 15, 2021 14:17
xsacha pushed a commit to xsacha/pytorch that referenced this pull request Mar 31, 2021
…them in script mode. (pytorch#52748) (pytorch#53308)

Summary:
Pull Request resolved: pytorch#53308

* Update tests for test_gru_* at this moment.

* Update flake8 error.

* Update tests for test_gru_* at this moment.

* Update flake8 error.

* Update test_gru_* test cases only.

* Fix flake8 issue.

* Fix flake8 issue on test.

* Still disable test cases created by make_test.

* Update code to fix issue 'AttributeError: 'RecursiveScriptModule' object has no attribute 'forward'' for test_elman_* test cases.

* Add script model support for test_lstm_* test cases.

Test Plan: Imported from OSS

Reviewed By: pbelevich, malfet

Differential Revision: D26922419

Pulled By: SplitInfinity

fbshipit-source-id: a96432b2e7da9b142a38f87fbaf56737117462c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants