-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Update test cases generated by make_test() method to support running them in script mode. (#52748) #53308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…them in script mode. (#52748) * Update tests for test_gru_* at this moment. * Update flake8 error. * Update tests for test_gru_* at this moment. * Update flake8 error. * Update test_gru_* test cases only. * Fix flake8 issue. * Fix flake8 issue on test. * Still disable test cases created by make_test. * Update code to fix issue 'AttributeError: 'RecursiveScriptModule' object has no attribute 'forward'' for test_elman_* test cases. * Add script model support for test_lstm_* test cases. [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 4fd29ad (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Mar 4, 2021
Closed
…rt running them in script mode. (#52748)" * Update tests for test_gru_* at this moment. * Update flake8 error. * Update tests for test_gru_* at this moment. * Update flake8 error. * Update test_gru_* test cases only. * Fix flake8 issue. * Fix flake8 issue on test. * Still disable test cases created by make_test. * Update code to fix issue 'AttributeError: 'RecursiveScriptModule' object has no attribute 'forward'' for test_elman_* test cases. * Add script model support for test_lstm_* test cases. [ghstack-poisoned]
This was referenced Mar 8, 2021
…rt running them in script mode. (#52748)" * Update tests for test_gru_* at this moment. * Update flake8 error. * Update tests for test_gru_* at this moment. * Update flake8 error. * Update test_gru_* test cases only. * Fix flake8 issue. * Fix flake8 issue on test. * Still disable test cases created by make_test. * Update code to fix issue 'AttributeError: 'RecursiveScriptModule' object has no attribute 'forward'' for test_elman_* test cases. * Add script model support for test_lstm_* test cases. [ghstack-poisoned]
…rt running them in script mode. (#52748)" * Update tests for test_gru_* at this moment. * Update flake8 error. * Update tests for test_gru_* at this moment. * Update flake8 error. * Update test_gru_* test cases only. * Fix flake8 issue. * Fix flake8 issue on test. * Still disable test cases created by make_test. * Update code to fix issue 'AttributeError: 'RecursiveScriptModule' object has no attribute 'forward'' for test_elman_* test cases. * Add script model support for test_lstm_* test cases. [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/BowenBao/38/base #53308 +/- ##
=======================================================
- Coverage 77.55% 77.55% -0.01%
=======================================================
Files 1874 1874
Lines 182979 182979
=======================================================
- Hits 141915 141907 -8
- Misses 41064 41072 +8 |
@SplitInfinity merged this pull request in be344e9. |
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
…them in script mode. (pytorch#52748) (pytorch#53308) Summary: Pull Request resolved: pytorch#53308 * Update tests for test_gru_* at this moment. * Update flake8 error. * Update tests for test_gru_* at this moment. * Update flake8 error. * Update test_gru_* test cases only. * Fix flake8 issue. * Fix flake8 issue on test. * Still disable test cases created by make_test. * Update code to fix issue 'AttributeError: 'RecursiveScriptModule' object has no attribute 'forward'' for test_elman_* test cases. * Add script model support for test_lstm_* test cases. Test Plan: Imported from OSS Reviewed By: pbelevich, malfet Differential Revision: D26922419 Pulled By: SplitInfinity fbshipit-source-id: a96432b2e7da9b142a38f87fbaf56737117462c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
[ONNX] Update inputs/input_names formatting to avoid ValueError with scriptMethods (#53519) #53548 [ONNX] Update inputs/input_names formatting to avoid ValueError with scriptMethods ([ONNX] Update inputs/input_names formatting to avoid ValueError with scriptMethods #53519)
[ONNX] fix export of embedding with padding_idx (#53053) #53530 [ONNX] fix export of embedding with padding_idx ([ONNX] fix export of embedding with padding_idx #53053)
[ONNX] Support torch.isinf, torch.any and torch.all export to ONNX (#53328) #53529 [ONNX] Support torch.isinf, torch.any and torch.all export to ONNX ([ONNX] Support torch.isinf, torch.any and torch.all export to ONNX #53328)
[ONNX] Update ONNX documentation (#51362) #53313 [ONNX] Update ONNX documentation ([ONNX] Update ONNX documentation #51362)
[ONNX] Add repeat_interleave symbolic (#52855) #53312 [ONNX] Add repeat_interleave symbolic ([ONNX] Add repeat_interleave symbolic #52855)
[ONNX] Update assign output shape for nested structure and dict output (#52893) #53311 [ONNX] Update assign output shape for nested structure and dict output ([ONNX] Update assign output shape for nested structure and dict output #52893)
Fix copy_ export (#53046) #53310 Fix copy_ export ([ONNX] Update export of copy_ #53046)
[ONNX] enable several script unit tests using new jit passes (#51722) #53309 [ONNX] enable several script unit tests using new jit passes ([ONNX] enable several script unit tests using new jit passes #51722)
Update test cases generated by make_test() method to support running them in script mode. (#52748) #53308 Update test cases generated by make_test() method to support running them in script mode. (Update test cases generated by make_test() method to support running them in script mode. #52748)
[ONNX] Symbolic shape inference (#51481) #53307 [ONNX] Symbolic shape inference ([ONNX] Symbolic shape inference #51481)
[ONNX] Support inplace operations on inplace indexing (#52063) #53306 [ONNX] Support inplace operations on inplace indexing ([ONNX] Support inplace operations on inplace indexing #52063)
[ONNX] Remove the last Cast in pow symbolic_opset9 (#52646) #53305 [ONNX] Remove the last Cast in pow symbolic_opset9 ([ONNX] Remove the last Cast in pow symbolic_opset9 #52646)
[ONNX] Redesign onnx pass to enable shape type dependent pattern conversion - cont (#51795) #53304 [ONNX] Redesign onnx pass to enable shape type dependent pattern conversion - cont ([ONNX] Redesign onnx pass to enable shape type dependent pattern conversion - cont #51795)
Update tests for test_gru_* at this moment.
Update flake8 error.
Update tests for test_gru_* at this moment.
Update flake8 error.
Update test_gru_* test cases only.
Fix flake8 issue.
Fix flake8 issue on test.
Still disable test cases created by make_test.
Update code to fix issue 'AttributeError: 'RecursiveScriptModule' object has no attribute 'forward'' for test_elman_* test cases.
Add script model support for test_lstm_* test cases.
Differential Revision: D26922419