Make storage access throw for meta tensors #53681
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without throwing, we can easily segfault trying to access nullptr storage. To do this I made set_storage_access_should_throw public so that you don't have to subclass TensorImpl to do it. An alternative is to just bite the bullet and add a MetaTensorImpl subclass. Let me know what is preferred. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
This was referenced Mar 10, 2021
💊 CI failures summary and remediationsAs of commit 3c77154 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Without throwing, we can easily segfault trying to access nullptr storage. To do this I made set_storage_access_should_throw public so that you don't have to subclass TensorImpl to do it. An alternative is to just bite the bullet and add a MetaTensorImpl subclass. Let me know what is preferred. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
bhosmer
approved these changes
Mar 10, 2021
It's not, in fact, I cannot think of any reason why I need to actually make a subclass and would prefer not to. |
Without throwing, we can easily segfault trying to access nullptr storage. To do this I made set_storage_access_should_throw public so that you don't have to subclass TensorImpl to do it. An alternative is to just bite the bullet and add a MetaTensorImpl subclass. Let me know what is preferred. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D26955540](https://our.internmc.facebook.com/intern/diff/D26955540) [ghstack-poisoned]
smessmer
approved these changes
Mar 11, 2021
Without throwing, we can easily segfault trying to access nullptr storage. To do this I made set_storage_access_should_throw public so that you don't have to subclass TensorImpl to do it. An alternative is to just bite the bullet and add a MetaTensorImpl subclass. Let me know what is preferred. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D26955540](https://our.internmc.facebook.com/intern/diff/D26955540) [ghstack-poisoned]
Without throwing, we can easily segfault trying to access nullptr storage. To do this I made set_storage_access_should_throw public so that you don't have to subclass TensorImpl to do it. An alternative is to just bite the bullet and add a MetaTensorImpl subclass. Let me know what is preferred. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D26955540](https://our.internmc.facebook.com/intern/diff/D26955540) [ghstack-poisoned]
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: Pull Request resolved: pytorch#53681 Without throwing, we can easily segfault trying to access nullptr storage. To do this I made set_storage_access_should_throw public so that you don't have to subclass TensorImpl to do it. An alternative is to just bite the bullet and add a MetaTensorImpl subclass. Let me know what is preferred. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: bhosmer Differential Revision: D26955540 Pulled By: ezyang fbshipit-source-id: 8ce22dd07ef1beb042f1d91de981954d59c2f84a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Without throwing, we can easily segfault trying to access nullptr
storage.
To do this I made set_storage_access_should_throw public so that you
don't have to subclass TensorImpl to do it. An alternative is
to just bite the bullet and add a MetaTensorImpl subclass. Let
me know what is preferred.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D26955540