ns for fx: extract common code in tests to util functions #53748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Extracts common testing patterns for FX numeric suite into util functions. No logic change. Test Plan: ``` python test/test_quantization.py TestFXNumericSuiteCoreAPIs python test/test_quantization.py TestFXNumericSuiteCoreAPIsModels ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Mar 10, 2021
💊 CI failures summary and remediationsAs of commit 8a5cd32 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
vkuzo
added a commit
that referenced
this pull request
Mar 10, 2021
Summary: Extracts common testing patterns for FX numeric suite into util functions. No logic change. Test Plan: ``` python test/test_quantization.py TestFXNumericSuiteCoreAPIs python test/test_quantization.py TestFXNumericSuiteCoreAPIsModels ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: cfdf697 Pull Request resolved: #53748
jerryzh168
approved these changes
Mar 10, 2021
This was referenced Mar 10, 2021
Summary: Extracts common testing patterns for FX numeric suite into util functions. No logic change. Test Plan: ``` python test/test_quantization.py TestFXNumericSuiteCoreAPIs python test/test_quantization.py TestFXNumericSuiteCoreAPIsModels ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D26967105](https://our.internmc.facebook.com/intern/diff/D26967105) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/vkuzo/252/base #53748 +/- ##
=====================================================
- Coverage 76.91% 76.91% -0.01%
=====================================================
Files 1889 1889
Lines 183723 183723
=====================================================
- Hits 141309 141302 -7
- Misses 42414 42421 +7 |
|
This pull request has been merged in 986e3c0. |
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
) Summary: Pull Request resolved: pytorch#53748 Extracts common testing patterns for FX numeric suite into util functions. No logic change. Test Plan: ``` python test/test_quantization.py TestFXNumericSuiteCoreAPIs python test/test_quantization.py TestFXNumericSuiteCoreAPIsModels ``` Imported from OSS Reviewed By: raghuramank100 Differential Revision: D26967105 fbshipit-source-id: 9f6cbe75bb6d2ede142929e0c9e40812006c159d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Extracts common testing patterns for FX numeric suite into
util functions. No logic change.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D26967105