Skip to content

[PyTorch] Fix string copy in WARN path for both interpreters #54076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[PyTorch] Fix string copy in WARN path for both interpreters #54076

wants to merge 2 commits into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 16, 2021 •
edited
Loading

Stack from ghstack:

If we don't constrain ourselves to use torch::jit::pop, we can avoid copying a string or moving IValues around.

Differential Revision: D27087204

@swolchok
[PyTorch] Fix string copy in WARN path for both interpreters
b463294 
If we don't constrain ourselves to use `torch::jit::pop`, we can avoid copying a string or moving IValues around.

Differential Revision: [D27087204](https://our.internmc.facebook.com/intern/diff/D27087204/)

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Mar 16, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 16, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 4c266ca (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_cpp_doc_build (1/1)

Step: "Doc Build and Push" (full log | diagnosis details | 🔁 rerun) ❄️

Mar 16 18:58:19 E: Unable to correct problems, you have held broken packages. 
Mar 16 18:58:19 Building dependency tree...
Mar 16 18:58:19 Reading state information...
Mar 16 18:58:19 Some packages could not be installed. This may mean that you have
Mar 16 18:58:19 requested an impossible situation or if you are using the unstable
Mar 16 18:58:19 distribution that some required packages have not yet been created
Mar 16 18:58:19 or been moved out of Incoming.
Mar 16 18:58:19 The following information may help to resolve the situation:
Mar 16 18:58:19 
Mar 16 18:58:19 The following packages have unmet dependencies:
Mar 16 18:58:19  doxygen : Depends: libclang1-3.8 (>= 3.2) but it is not going to be installed
Mar 16 18:58:19 E: Unable to correct problems, you have held broken packages.


Exited with code exit status 100
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@swolchok swolchok mentioned this pull request Mar 16, 2021
Closed
@swolchok
format on "[PyTorch] Fix string copy in WARN path for both interpreters"
4c266ca 
If we don't constrain ourselves to use `torch::jit::pop`, we can avoid copying a string or moving IValues around.

Differential Revision: [D27087204](https://our.internmc.facebook.com/intern/diff/D27087204/)

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 16, 2021
@swolchok
[PyTorch] Fix string copy in WARN path for both interpreters
e9f69c2 
Pull Request resolved: #54076

If we don't constrain ourselves to use `torch::jit::pop`, we can avoid copying a string or moving IValues around.
ghstack-source-id: 124040891

Differential Revision: [D27087204](https://our.internmc.facebook.com/intern/diff/D27087204/)
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 4a24c55.

@facebook-github-bot facebook-github-bot deleted the gh/swolchok/157/head branch March 21, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swolchok @facebook-github-bot