Skip to content

Conversation

janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Mar 16, 2021

This will allow for future work to use the test times file (which will save computation time and also allow for more consistency). (Step one to fixing #53882)

Test plan:
export CIRCLE_JOB=your-favorite-circleci-job e.g., pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2
python test/run_test.py --export-historic-test-times OR
python test/run_test.py --export-historic-test-times .your-favorite-file

When opening either .pytorch-test-times or .your-favorite-file, you should see something like:

{"commit": "2d559a09392aabb84dfb4a498010b2f01d99818c", "job_times": {"distributed/test_distributed_spawn": 583.5889999999973, "distributed/test_data_parallel": 4.866999999999997, "test_binary_ufuncs": 171.1569999999998, "test_numpy_interop": 2.5649999999999995, "test_public_bindings": 0.011,...}}

Note that no tests will be run when this option is specified.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 16, 2021

💊 CI failures summary and remediations

As of commit 6bd60dd (more details on the Dr. CI page):


  • 7/7 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build binary_windows_libtorch_3_7_cpu_release_build (1/2)

Step: "Checkout pytorch/builder repo" (full log | diagnosis details | 🔁 rerun)

Waiting for a VM assignment: ................
Build-agent version 1.0.54207-5704a5fc (2021-03-16T17:42:41+0000)
Creating a dedicated VM with windows-server-2019-vs2019:stable image
Waiting for a VM assignment: ................
Assigned VM request id: 23522171
  provisioning: 
VM 'default-d5760675-e645-4d14-ade9-6f93b43116c9' has been created
Initializing agent


Unexpected environment preparation error: failed to create working directory /tmp/605225efd4799a7459b4b1ce-0-build: ssh connection failed

See CircleCI build pytorch_linux_xenial_py3_clang7_onnx_ort_test1 (2/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Error: No such container:path: 0de4401c55c5170f095479453f032cad29e616b7ed30132d4a900e7af228af4c:/var/lib/jenkins/workspace/test/.coverage
Mar 17 16:44:29     * 252916ab61          1 report,  total time   847.22s
Mar 17 16:44:29     * c4f50162be          1 report,  total time   820.65s
Mar 17 16:44:29     |
Mar 17 16:44:29     :
Mar 17 16:44:29 
Mar 17 16:44:29 Removed  (across    0 suites)     0 tests, totaling     0.00s
Mar 17 16:44:29 Modified (across    0 suites)     0 tests, totaling     0.00s
Mar 17 16:44:29 Added    (across    0 suites)     0 tests, totaling     0.00s
Retrieving test reports
Retrieving Python coverage report
Error: No such container:path: 0de4401c55c5170f095479453f032cad29e616b7ed30132d4a900e7af228af4c:/var/lib/jenkins/workspace/test/.coverage


Exited with code exit status 1


5 failures not recognized by patterns:

Job Step Action
CircleCI pytorch_linux_bionic_py3_8_gcc9_coverage_test1 Run tests 🔁 rerun
CircleCI pytorch_linux_xenial_py3_clang5_android_ndk_r19c_x86_32_build Build 🔁 rerun
CircleCI binary_windows_libtorch_3_7_cpu_debug_build Build 🔁 rerun
CircleCI pytorch_windows_vs2019_py36_cuda10.1_build Checkout code 🔁 rerun
CircleCI pytorch_windows_vs2019_py36_cpu_build Build 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@janeyx99 janeyx99 requested a review from a team March 16, 2021 19:23
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janeyx99 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@walterddr walterddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@janeyx99 janeyx99 force-pushed the add-dumping-option branch from 9f26cd2 to 6bd60dd Compare March 17, 2021 15:53
@janeyx99 janeyx99 changed the title Add dump-test-times option to dump S3 test times into a JSON file Add export-historic-test-times option to dump S3 test times into a JSON file Mar 17, 2021
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janeyx99 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@janeyx99 merged this pull request in f30a7a2.

@janeyx99 janeyx99 deleted the add-dumping-option branch March 17, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants