Skip to content

Conversation

wconstab
Copy link
Contributor

Summary:
Construct InterpreterManager inside PyTorchDeployModel

  • add ReadAdapterInterface to deploy::Package
    Basic test of loading and executing 'simple' model
  • skip Example/IValue/schema logic for now

Implement PyTorchDeployModel::makePrediction for FeatureStore Examples

  • WIP still but have passed a simple e2e test

Runs locally in opt and dbg, but not dev

  • debugging LSAN issue in dev mode

needs -c=python.package_style=inplace currently or generate_packages fails,

e.g.
buck test mode/opt -c=python.package_style=inplace //fblearner/predictor/model/tests:pytorch_deploy_model_test
should pass

Differential Revision: D26961744

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 17, 2021

💊 CI failures summary and remediations

As of commit a43e85e (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build clang-tidy (1/1)

Step: "Add annotations" (full log | diagnosis details | 🔁 rerun)

2021-03-19T05:08:49.7158454Z update-alternatives: error: no alternatives for nsight-sys
2021-03-19T05:08:49.5863290Z Setting up x11proto-damage-dev (1:2018.4-4) ...
2021-03-19T05:08:49.5902677Z Setting up cuda-nvjpeg-10-2 (10.2.89-1) ...
2021-03-19T05:08:49.5983696Z Setting up libxcb-dri3-dev:amd64 (1.13-2~ubuntu18.04) ...
2021-03-19T05:08:49.6016320Z Setting up libcublas10 (10.2.3.254-1) ...
2021-03-19T05:08:49.6056805Z Setting up libcublas-dev (10.2.3.254-1) ...
2021-03-19T05:08:49.6088388Z Setting up cuda-cufft-10-2 (10.2.89-1) ...
2021-03-19T05:08:49.6170215Z Setting up cuda-nsight-compute-10-2 (10.2.89-1) ...
2021-03-19T05:08:49.6203935Z Setting up nsight-systems-2020.4.3 (2020.4.3.7-10543b6) ...
2021-03-19T05:08:49.6300419Z update-alternatives: using /opt/nvidia/nsight-systems/2020.4.3/target-linux-x64/nsys to provide /usr/local/bin/nsys (nsys) in auto mode
2021-03-19T05:08:49.7149609Z update-alternatives: error: alternative path /opt/nvidia/nsight-systems/2020.4.3/host-linux-x64/nsight-sys doesn't exist
2021-03-19T05:08:49.7158454Z update-alternatives: error: no alternatives for nsight-sys
2021-03-19T05:08:49.7219825Z update-alternatives: using /opt/nvidia/nsight-systems/2020.4.3/host-linux-x64/nsys-ui to provide /usr/local/bin/nsys-ui (nsys-ui) in auto mode
2021-03-19T05:08:49.7278240Z Setting up libxcb-shape0-dev:amd64 (1.13-2~ubuntu18.04) ...
2021-03-19T05:08:49.7313392Z Setting up cuda-cusparse-10-2 (10.2.89-1) ...
2021-03-19T05:08:49.7402286Z Setting up cuda-cuobjdump-10-2 (10.2.89-1) ...
2021-03-19T05:08:49.7430284Z Setting up libxcb-glx0-dev:amd64 (1.13-2~ubuntu18.04) ...
2021-03-19T05:08:49.7472027Z Setting up libgles2:amd64 (1.0.0-2ubuntu2.3) ...
2021-03-19T05:08:49.7503271Z Setting up libglu1-mesa:amd64 (9.0.0-2.1build1) ...
2021-03-19T05:08:49.7551034Z Setting up libegl-mesa0:amd64 (20.0.8-0ubuntu1~18.04.1) ...
2021-03-19T05:08:49.7652169Z Setting up cuda-sanitizer-api-10-2 (10.2.89-1) ...
2021-03-19T05:08:49.7749899Z Setting up cuda-nvjpeg-dev-10-2 (10.2.89-1) ...

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D26961744

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #54120 (a43e85e) into master (8f755b9) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #54120   +/-   ##
=======================================
  Coverage   77.46%   77.46%           
=======================================
  Files        1891     1891           
  Lines      185210   185210           
=======================================
+ Hits       143464   143473    +9     
+ Misses      41746    41737    -9     

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D26961744

Summary:
Pull Request resolved: pytorch#54120

Construct InterpreterManager inside PyTorchDeployModel
 - add ReadAdapterInterface to deploy::Package

Implement PyTorchDeployModel::makePrediction for FeatureStore Examples
- Basic test of loading and executing 'simple' model

Test Plan: ran unit tests locally and CI

Differential Revision: D26961744

fbshipit-source-id: 32928095983d87785c5c2fda93bdb71ce91a863a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D26961744

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 2662e34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants