Skip to content

Conversation

@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Mar 18, 2021

Since both these files were deleted back in time, we shouldn't be running them anymore, as this was the old sharding strategy (see #50660).

test_python_nn.bat
test_python_all_except_nn.bat

I believe we intend to run all the python files, so I added a call for that instead.

Note: I don't believe there is a single unsharded test build, though, so should I instead just assume that all windows tests will be sharded?

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 18, 2021

💊 CI failures summary and remediations

As of commit 7c45999 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@janeyx99 janeyx99 requested review from a team, mszhanyi and peterjc123 March 18, 2021 22:05
Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very useful

@facebook-github-bot
Copy link
Contributor

@janeyx99 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@janeyx99 merged this pull request in 7549816.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants