Skip to content

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Mar 19, 2021

Stack from ghstack:

Summary:

Makes input logging work properly for multi-node subgraphs.

Test Plan:

python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_linear_fp16_shadow_activations

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D27190137

Summary:

Makes input logging work properly for multi-node subgraphs.

Test Plan:

```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_linear_fp16_shadow_activations
```

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 19, 2021

💊 CI failures summary and remediations

As of commit 2c63d1a (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

vkuzo added a commit that referenced this pull request Mar 19, 2021
Summary:

Makes input logging work properly for multi-node subgraphs.

Test Plan:

```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_linear_fp16_shadow_activations
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 66f901f
Pull Request resolved: #54327
@vkuzo vkuzo changed the title ns for fx: make input logging work for multi node subgraphs ns for fx: make shadow input logging work for multi node subgraphs Mar 19, 2021
@vkuzo vkuzo requested review from hx89 and jerryzh168 March 19, 2021 17:03
vkuzo added 2 commits March 23, 2021 21:16
…ubgraphs"

Summary:

Makes input logging work properly for multi-node subgraphs.

Test Plan:

```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_linear_fp16_shadow_activations
```

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D27190137](https://our.internmc.facebook.com/intern/diff/D27190137)

[ghstack-poisoned]
…ubgraphs"

Summary:

Makes input logging work properly for multi-node subgraphs.

Test Plan:

```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_linear_fp16_shadow_activations
```

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D27190137](https://our.internmc.facebook.com/intern/diff/D27190137)

[ghstack-poisoned]
…ubgraphs"

Summary:

Makes input logging work properly for multi-node subgraphs.

Test Plan:

```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_linear_fp16_shadow_activations
```

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D27190137](https://our.internmc.facebook.com/intern/diff/D27190137)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 5319d17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants