-
Notifications
You must be signed in to change notification settings - Fork 25.6k
ns for fx: make shadow input logging work for multi node subgraphs #54327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Makes input logging work properly for multi-node subgraphs. Test Plan: ``` python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_linear_fp16_shadow_activations ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Mar 19, 2021
This was referenced Mar 19, 2021
💊 CI failures summary and remediationsAs of commit 2c63d1a (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Mar 19, 2021
…ubgraphs" Summary: Makes input logging work properly for multi-node subgraphs. Test Plan: ``` python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_linear_fp16_shadow_activations ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27190137](https://our.internmc.facebook.com/intern/diff/D27190137) [ghstack-poisoned]
…ubgraphs" Summary: Makes input logging work properly for multi-node subgraphs. Test Plan: ``` python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_linear_fp16_shadow_activations ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27190137](https://our.internmc.facebook.com/intern/diff/D27190137) [ghstack-poisoned]
hx89
approved these changes
Mar 31, 2021
…ubgraphs" Summary: Makes input logging work properly for multi-node subgraphs. Test Plan: ``` python test/test_quantization.py TestFXNumericSuiteCoreAPIs.test_linear_fp16_shadow_activations ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27190137](https://our.internmc.facebook.com/intern/diff/D27190137) [ghstack-poisoned]
This was referenced Mar 31, 2021
This pull request has been merged in 5319d17. |
This was referenced Apr 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Makes input logging work properly for multi-node subgraphs.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D27190137