Enable complex autograd for `index`, add `index` and `index_put` OpInfos #54562

kurtamohler · 2021-03-24T02:50:41Z

Fixes #53605

facebook-github-bot · 2021-03-24T02:50:50Z

💊 CI failures summary and remediations

As of commit a8996ec (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

anjali411 · 2021-03-24T18:43:57Z

torch/testing/_internal/common_methods_invocations.py

+           supports_inplace_autograd=True,
+           sample_inputs_func=sample_inputs_index_put,
+           skips=(
+               SkipInfo('TestCommon', 'test_variant_consistency_jit'),


why is this test being skipped? if it's intentionally skipped due to a test failure, could you share the error message or the reason why it's failing?

Yeah there's a failure that I don't understand yet:

click to expand

====================================================================== ERROR: test_variant_consistency_jit_index_put_cpu_float32 (__main__.TestCommonCPU) ---------------------------------------------------------------------- Traceback (most recent call last): File "/work2/kurtamohler/development/pytorch-index_put-complex-autograd/torch/testing/_internal/common_device_type.py", line 297, in instantiated_test raise rte File "/work2/kurtamohler/development/pytorch-index_put-complex-autograd/torch/testing/_internal/common_device_type.py", line 292, in instantiated_test result = test_fn(self, *args) File "/work2/kurtamohler/development/pytorch-index_put-complex-autograd/torch/testing/_internal/common_device_type.py", line 266, in test_wrapper return test(*args, **kwargs) File "/work2/kurtamohler/development/pytorch-index_put-complex-autograd/test/test_ops.py", line 294, in test_variant_consistency_jit check_against_reference(self, File "/work2/kurtamohler/development/pytorch-index_put-complex-autograd/torch/testing/_internal/common_jit.py", line 63, in check_against_reference outputs_test = self.runAndSaveRNG(func, nograd_inputs, kwargs) File "/work2/kurtamohler/development/pytorch-index_put-complex-autograd/torch/testing/_internal/common_jit.py", line 130, in runAndSaveRNG results = func(*inputs, **kwargs) File "/work2/kurtamohler/development/pytorch-index_put-complex-autograd/torch/testing/_internal/jit_metaprogramming_utils.py", line 301, in script_fn fn, tensors = gen_script_fn_and_args(method_name, func_type, *args, **kwargs) File "/work2/kurtamohler/development/pytorch-index_put-complex-autograd/torch/testing/_internal/jit_metaprogramming_utils.py", line 292, in gen_script_fn_and_args CU = torch.jit.CompilationUnit(script) RuntimeError: undefined value tensor: File "<string>", line 3 def the_method(i0, i1): return torch.index_put(i0, (tensor([4, 4]),), i1, accumulate=False)

Seems like it must be an existing issue that this PR did not introduce, but I could look into it anyway

anjali411 · 2021-03-24T18:44:15Z

torch/testing/_internal/common_methods_invocations.py

+           supports_inplace_autograd=False,
+           op=torch.Tensor.__getitem__,
+           sample_inputs_func=sample_inputs_getitem,
+           skips=(SkipInfo('TestCommon', 'test_variant_consistency_jit'),)),


same comment as below

This is the failure for this one:

click to expand

====================================================================== ERROR: test_variant_consistency_jit_index_put_cuda_float32 (__main__.TestCommonCUDA) ---------------------------------------------------------------------- Traceback (most recent call last): File "/work2/kurtamohler/development/pytorch-index_put-complex-autograd/torch/testing/_internal/common_utils.py", line 955, in wrapper method(*args, **kwargs) File "/work2/kurtamohler/development/pytorch-index_put-complex-autograd/torch/testing/_internal/common_utils.py", line 955, in wrapper method(*args, **kwargs) File "/work2/kurtamohler/development/pytorch-index_put-complex-autograd/torch/testing/_internal/common_device_type.py", line 297, in instantiated_test raise rte File "/work2/kurtamohler/development/pytorch-index_put-complex-autograd/torch/testing/_internal/common_device_type.py", line 292, in instantiated_test result = test_fn(self, *args) File "/work2/kurtamohler/development/pytorch-index_put-complex-autograd/torch/testing/_internal/common_device_type.py", line 266, in test_wrapper return test(*args, **kwargs) File "/work2/kurtamohler/development/pytorch-index_put-complex-autograd/test/test_ops.py", line 294, in test_variant_consistency_jit check_against_reference(self, File "/work2/kurtamohler/development/pytorch-index_put-complex-autograd/torch/testing/_internal/common_jit.py", line 63, in check_against_reference outputs_test = self.runAndSaveRNG(func, nograd_inputs, kwargs) File "/work2/kurtamohler/development/pytorch-index_put-complex-autograd/torch/testing/_internal/common_jit.py", line 130, in runAndSaveRNG results = func(*inputs, **kwargs) File "/work2/kurtamohler/development/pytorch-index_put-complex-autograd/torch/testing/_internal/jit_metaprogramming_utils.py", line 301, in script_fn fn, tensors = gen_script_fn_and_args(method_name, func_type, *args, **kwargs) File "/work2/kurtamohler/development/pytorch-index_put-complex-autograd/torch/testing/_internal/jit_metaprogramming_utils.py", line 292, in gen_script_fn_and_args CU = torch.jit.CompilationUnit(script) RuntimeError: undefined value tensor: File "<string>", line 3 def the_method(i0, i1): return torch.index_put(i0, (tensor([0, 1], device='cuda:0'),), i1, accumulate=False) ~~~~~~ <--- HERE

no idea how to fix this off the top of my head. let's follow up on this in a separate issue/subsequent PR?

@kurtamohler did you get a chance to look into this?

anjali411

thanks @kurtamohler ! This PR lgtm overall. I just have one question regarding the skip, but besides that this PR is ready to be merged.

facebook-github-bot · 2021-03-24T18:46:22Z

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

anjali411 · 2021-03-26T04:09:29Z

@kurtamohler could you please rebase?

codecov · 2021-03-26T07:37:14Z

Codecov Report

Merging #54562 (0f27544) into master (4e5af53) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0f27544 differs from pull request most recent head a8996ec. Consider uploading reports for the commit a8996ec to get more accurate results

@@            Coverage Diff             @@
##           master   #54562      +/-   ##
==========================================
- Coverage   77.45%   77.45%   -0.01%     
==========================================
  Files        1894     1893       -1     
  Lines      186401   186105     -296     
==========================================
- Hits       144377   144143     -234     
+ Misses      42024    41962      -62

facebook-github-bot · 2021-03-26T14:16:37Z

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

anjali411 · 2021-03-29T15:59:16Z

@kurtamohler looks like another PR went in before this one. needs another rebase!

kurtamohler · 2021-03-29T19:07:57Z

@anjali411, rebase done

facebook-github-bot · 2021-03-29T19:17:15Z

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-03-29T21:38:30Z

@anjali411 merged this pull request in 49b07ac.

kurtamohler requested a review from anjali411 March 24, 2021 02:50

kurtamohler requested review from albanD and soulitzer as code owners March 24, 2021 02:50

facebook-github-bot added the cla signed label Mar 24, 2021

pytorchbot added the open source label Mar 24, 2021

kurtamohler force-pushed the index-complex-autograd branch from b0ec1a7 to d605e4d Compare March 24, 2021 03:07

Enable complex autograd for index, add index and index_put OpInfos

34fa046

kurtamohler force-pushed the index-complex-autograd branch from d605e4d to 34fa046 Compare March 24, 2021 17:37

anjali411 reviewed Mar 24, 2021

View reviewed changes

anjali411 approved these changes Mar 24, 2021

View reviewed changes

Merge branch 'master' into index-complex-autograd

0f27544

kurtamohler mentioned this pull request Mar 26, 2021

Add complex autograd support for torch.linalg.det #54787

Closed

Merge branch 'master' into index-complex-autograd

a8996ec

facebook-github-bot closed this in 49b07ac Mar 29, 2021

facebook-github-bot added the Merged label Mar 29, 2021

Enable complex autograd for index, add index and index_put OpInfos #54562

Enable complex autograd for index, add index and index_put OpInfos #54562

Uh oh!

Conversation

kurtamohler commented Mar 24, 2021

Uh oh!

facebook-github-bot commented Mar 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

Uh oh!

anjali411 Mar 24, 2021

Choose a reason for hiding this comment

Uh oh!

kurtamohler Mar 24, 2021

Choose a reason for hiding this comment

Uh oh!

anjali411 Mar 24, 2021

Choose a reason for hiding this comment

Uh oh!

kurtamohler Mar 24, 2021

Choose a reason for hiding this comment

Uh oh!

anjali411 Mar 26, 2021

Choose a reason for hiding this comment

Uh oh!

anjali411 Mar 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anjali411 left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Mar 24, 2021

Uh oh!

anjali411 commented Mar 26, 2021

Uh oh!

codecov bot commented Mar 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

facebook-github-bot commented Mar 26, 2021

Uh oh!

anjali411 commented Mar 29, 2021

Uh oh!

kurtamohler commented Mar 29, 2021

Uh oh!

facebook-github-bot commented Mar 29, 2021

Uh oh!

facebook-github-bot commented Mar 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Enable complex autograd for `index`, add `index` and `index_put` OpInfos #54562

Enable complex autograd for `index`, add `index` and `index_put` OpInfos #54562

facebook-github-bot commented Mar 24, 2021 •

edited

Loading

anjali411 Mar 29, 2021 •

edited

Loading

codecov bot commented Mar 26, 2021 •

edited

Loading