[DDP logging] Prefer use of c10::Join #54649
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some operator<< code manually implemented string join in C++, turns out there is a c10 util for this. Use the util instead of rolling our own. Differential Revision: [D27316705](https://our.internmc.facebook.com/intern/diff/D27316705/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 801145c (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
rohan-varma
added a commit
that referenced
this pull request
Mar 25, 2021
Some operator<< code manually implemented string join in C++, turns out there is a c10 util for this. Use the util instead of rolling our own. Differential Revision: [D27316705](https://our.internmc.facebook.com/intern/diff/D27316705/) ghstack-source-id: 124840043 Pull Request resolved: #54649
wayi1
approved these changes
Mar 25, 2021
Yeah, looks like there are quite a lot of utils in c10/ dir that I was previously unaware of - I should probably check there before implementing common things one off in the future. |
Codecov Report
@@ Coverage Diff @@
## gh/rohan-varma/268/base #54649 +/- ##
===========================================================
- Coverage 77.47% 77.47% -0.01%
===========================================================
Files 1893 1893
Lines 185802 185795 -7
===========================================================
- Hits 143948 143941 -7
Misses 41854 41854 |
|
This pull request has been merged in 6b7652e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Some operator<< code manually implemented string join in C++, turns
out there is a c10 util for this. Use the util instead of rolling our own.
Differential Revision: D27316705