[test_c10d] Add wait in nccl high priority stream test #54714
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add wait in test_pass_nccl_options_high_priority_stream after the all reduce operation. Without wait, the allreduce operation might be still running and the comparison of result might not be valid. Signed-off-by: Jagadish Krishnamoorthy <jagdish.krishna@gmail.com>
jaglinux
requested review from
H-Huang,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
facebook-github-bot
added
oncall: distributed
💊 CI failures summary and remediationsAs of commit 99352b5 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
wayi1
approved these changes
Mar 25, 2021
|
Thanks for the fix! |
Codecov Report
@@ Coverage Diff @@
## master #54714 +/- ##
==========================================
- Coverage 77.43% 77.02% -0.42%
==========================================
Files 1893 1893
Lines 186083 186083
==========================================
- Hits 144098 143331 -767
- Misses 41985 42752 +767 |
|
Can someone please approve and merge ? When the test is run in loop without the fix, the test fails consistently. |
pritamdamania87
approved these changes
Mar 27, 2021
|
@pritamdamania87 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 316804e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wait in test_pass_nccl_options_high_priority_stream
after the all reduce operation.
Without wait, the allreduce operation might be still running and the
comparison of result might not be valid.
Signed-off-by: Jagadish Krishnamoorthy jagdish.krishna@gmail.com