make all arguments in test_history.py optional kwarg #54797
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit b2674a4 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
samestep
reviewed
Mar 26, 2021
samestep
reviewed
Mar 26, 2021
samestep
reviewed
Mar 26, 2021
samestep
reviewed
Mar 26, 2021
walterddr
force-pushed
the
be_add_base_test_history_puller
branch
from
89ff0cf to
605cf24
Compare
samestep
reviewed
Mar 26, 2021
samestep
reviewed
Mar 26, 2021
samestep
reviewed
Mar 26, 2021
walterddr
force-pushed
the
be_add_base_test_history_puller
branch
from
605cf24 to
820a8f3
Compare
samestep
approved these changes
Mar 26, 2021
|
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
walterddr
force-pushed
the
be_add_base_test_history_puller
branch
from
820a8f3 to
b2674a4
Compare
|
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Codecov Report
@@ Coverage Diff @@
## master #54797 +/- ##
==========================================
- Coverage 77.41% 77.40% -0.01%
==========================================
Files 1893 1893
Lines 186208 186208
==========================================
- Hits 144144 144135 -9
- Misses 42064 42073 +9 |
|
@walterddr merged this pull request in 2fd1eb3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make it more flexible to be reused when pulling test stats other than by-test-case.
Also it makes it less likely to use it wrong with positional arguments.
Test Plan
see the updated tools/test/test_test_history.py examples.