-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[testing] clamp: test with either min or max #54939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testing] clamp: test with either min or max #54939
Conversation
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 8d3eef6 (more details on the Dr. CI page): Commit 8d3eef6 was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This is cool but I'm wondering if we should continue to treat clamp as a unary op since @peterbell10 is working on adding support min and max tensors, see here: #52695. What are your thoughts, @peterbell10? |
|
In my PR I keep the existing |
|
Sorry @kshitij12345, looks like this slipped through the cracks. With @peterbell10's answer and updates to common_method_invocations.py, are there parts of this PR we still want? If so, let's update it and get it landed quickly! |
|
Ping on this older PR, too, @kshitij12345 -- is there something here we should update and land or should we close this? |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
NOTE to self : Verify if the changes are still relevant. |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Follow-up from #52194 based on comment #52194 (comment)