[TensorExpr] Nuke BaseCallNode. #54999
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaseCallNode was used as a base class for Intrinsics and FunctionCall. Now FunctionCall is gone, so BaseCallNode could be removed as well. [ghstack-poisoned]
facebook-github-bot
added
oncall: jit
This was referenced Mar 30, 2021
💊 CI failures summary and remediationsAs of commit 65a3889 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Mar 30, 2021
ZolotukhinM
requested review from
Chillee,
bertmaher and
navahgar
and removed request for
navahgar
BaseCallNode was used as a base class for Intrinsics and FunctionCall. Now FunctionCall is gone, so BaseCallNode could be removed as well. Differential Revision: [D27446411](https://our.internmc.facebook.com/intern/diff/D27446411) [ghstack-poisoned]
added 3 commits
March 30, 2021 22:34
BaseCallNode was used as a base class for Intrinsics and FunctionCall. Now FunctionCall is gone, so BaseCallNode could be removed as well. Differential Revision: [D27446411](https://our.internmc.facebook.com/intern/diff/D27446411) [ghstack-poisoned]
BaseCallNode was used as a base class for Intrinsics and FunctionCall. Now FunctionCall is gone, so BaseCallNode could be removed as well. Differential Revision: [D27446411](https://our.internmc.facebook.com/intern/diff/D27446411) [ghstack-poisoned]
BaseCallNode was used as a base class for Intrinsics and FunctionCall. Now FunctionCall is gone, so BaseCallNode could be removed as well. Differential Revision: [D27446411](https://our.internmc.facebook.com/intern/diff/D27446411) [ghstack-poisoned]
|
@ZolotukhinM merged this pull request in bdbfb2a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
BaseCallNode was used as a base class for Intrinsics and FunctionCall.
Now FunctionCall is gone, so BaseCallNode could be removed as well.
Differential Revision: D27446411