[caffe2] Shape inference for Transpose #55188
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 2984837 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D27514487 |
Summary: Pull Request resolved: pytorch#55188 We need to make sure dim types are preserved after applying Transpose. Test Plan: ``` $ buck build caffe2/caffe2/opt:bound_shape_inference_test && ./buck-out/gen/caffe2/caffe2/opt/bound_shape_inference_test --gtest_filter=*Transpose* ``` Reviewed By: yinghai Differential Revision: D27514487 fbshipit-source-id: 1c1bc56124405493af87f50822f4362cb7c2842f
khabinov
force-pushed
the
export-D27514487
branch
from
8f7de69 to
2984837
Compare
|
This pull request was exported from Phabricator. Differential Revision: D27514487 |
Codecov Report
@@ Coverage Diff @@
## master #55188 +/- ##
=======================================
Coverage 77.39% 77.39%
=======================================
Files 1897 1897
Lines 187160 187160
=======================================
+ Hits 144848 144850 +2
+ Misses 42312 42310 -2 |
|
This pull request has been merged in 28531c9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We need to make sure dim types are preserved after applying Transpose.
Test Plan:
Reviewed By: yinghai
Differential Revision: D27514487