-
Notifications
You must be signed in to change notification settings - Fork 25.6k
fix typo in argmax docstring #55239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo in argmax docstring #55239
Conversation
Hi @ACactus! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
💊 CI failures summary and remediationsAs of commit 10622ca (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #55239 +/- ##
==========================================
- Coverage 77.43% 77.43% -0.01%
==========================================
Files 1895 1895
Lines 187001 187001
==========================================
- Hits 144812 144811 -1
- Misses 42189 42190 +1 |
@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: argmax docstring previously said that it returns indexes of the first 'minimal' value, fixed typo in that line to 'maximal' Pull Request resolved: pytorch#55239 Reviewed By: albanD Differential Revision: D27641562 Pulled By: mrshenli fbshipit-source-id: f8b5c579400088b5210c83a05da6c4c106fbf95d
argmax docstring previously said that it returns indexes of the first 'minimal' value, fixed typo in that line to 'maximal'