Skip to content

Conversation

nkgrush
Copy link
Contributor

@nkgrush nkgrush commented Apr 2, 2021

argmax docstring previously said that it returns indexes of the first 'minimal' value, fixed typo in that line to 'maximal'

@facebook-github-bot
Copy link
Contributor

Hi @ACactus!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 2, 2021

💊 CI failures summary and remediations

As of commit 10622ca (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #55239 (10622ca) into master (181de40) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #55239      +/-   ##
==========================================
- Coverage   77.43%   77.43%   -0.01%     
==========================================
  Files        1895     1895              
  Lines      187001   187001              
==========================================
- Hits       144812   144811       -1     
- Misses      42189    42190       +1     

@facebook-github-bot
Copy link
Contributor

@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mrshenli mrshenli added module: docs Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Apr 8, 2021
@facebook-github-bot
Copy link
Contributor

@mrshenli merged this pull request in 80d04f9.

krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
Summary:
argmax docstring previously said that it returns indexes of the first 'minimal' value, fixed typo in that line to 'maximal'

Pull Request resolved: pytorch#55239

Reviewed By: albanD

Differential Revision: D27641562

Pulled By: mrshenli

fbshipit-source-id: f8b5c579400088b5210c83a05da6c4c106fbf95d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged module: docs Related to our documentation, both in docs/ and docblocks open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants