Skip to content

Back out "[quant][graphmode][fx] Separate handling Copy operator to a helper function" #55388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Back out "[quant][graphmode][fx] Separate handling Copy operator to a helper function" #55388

wants to merge 1 commit into from

Conversation

bradleyhd
Copy link
Contributor

Summary: temporarily revert D27314678 (c57541c), it appears to cause a perf regression that makes quantization of some models take too long to complete tests.

Reviewed By: houseroad

Differential Revision: D27583809

@bradleyhd @facebook-github-bot
Back out "[quant][graphmode][fx] Separate handling Copy operator to a…
eb775a3 
… helper function"

Summary: temporarily revert D27314678 (pytorch@c57541c), it appears to cause a perf regression that makes quantization of some models take too long to complete tests.

Reviewed By: houseroad

Differential Revision: D27583809

fbshipit-source-id: bbe687e9a0360ca664f17b2ec80fc34faca49969
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 6, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit eb775a3 (more details on the Dr. CI page):

  • 1/2 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)
  • 1/2 broken upstream at merge base 158cdec on Apr 06 from 8:32am to 12:20pm

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D27583809

houseroad
houseroad approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

houseroad
houseroad reviewed Apr 6, 2021
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bc test breakage should be unrelated!

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 8eaa4a9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houseroad houseroad houseroad approved these changes

Assignees

No one assigned

Labels

cla signed fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bradleyhd @facebook-github-bot @houseroad