Avoid infinite recursion in __torch_function__ example #55391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 4612145 (more details on the Dr. CI page):
1 failure not recognized by patterns:
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
hameerabbasi
approved these changes
Apr 6, 2021
|
Thanks @peterbell10! This fix makes sense to me but I've requested a review from @ezyang. |
hameerabbasi
reviewed
Apr 7, 2021
|
just goes to show we need to run our doc examples haha |
ezyang
approved these changes
Apr 7, 2021
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Codecov Report
@@ Coverage Diff @@
## master #55391 +/- ##
==========================================
- Coverage 77.48% 77.06% -0.42%
==========================================
Files 1895 1895
Lines 187193 187193
==========================================
- Hits 145049 144267 -782
- Misses 42144 42926 +782 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55284
This gets the example to run but probably doesn't help the readability of the example.
Thoughts?