Skip to content

Add cross OpInfo #55483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add cross OpInfo #55483

wants to merge 1 commit into from

Conversation

mruberry
Copy link
Collaborator

@mruberry mruberry commented Apr 7, 2021

One of the tasks in #54261.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit cfac3fd (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

1 failure not recognized by patterns:

Job Step Action
GitHub Actions clang-format / clang-format Run clang-format 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@mruberry mruberry requested a review from anjali411 April 7, 2021 18:18
@imaginary-person
Copy link
Contributor

imaginary-person commented Apr 7, 2021 •
edited
Loading

Lots of OpInfos added today. I'll be careful not to duplicate :)

@codecov
Copy link

codecov bot commented Apr 7, 2021 •
edited
Loading

Codecov Report

Merging #55483 (cfac3fd) into master (41099ef) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #55483      +/-   ##
==========================================
- Coverage   77.65%   77.47%   -0.19%     
==========================================
  Files        1957     1957              
  Lines      195142   195146       +4     
==========================================
- Hits       151542   151189     -353     
- Misses      43600    43957     +357

@mruberry mruberry mentioned this pull request Apr 8, 2021
Closed
mruberry
mruberry commented Apr 12, 2021
View reviewed changes
torch/testing/_internal/common_methods_invocations.py Outdated
# Resized a non-empty tensor but did not warn about it.
SkipInfo('TestCommon', 'test_out'),
)
),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: make flake happy

anjali411
anjali411 approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@anjali411 anjali411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Please remove the autograd tests added in this PR: #55854

@facebook-github-bot
Copy link
Contributor

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mruberry merged this pull request in 4a872f8.

@mrshenli
Copy link
Contributor

mrshenli commented May 3, 2021

Hey @mruberry pytorch_windows_vs2019_py36_cuda11.1_test1 starts to fail after this commit. Do you know if that failure is relevant to this PR?

https://app.circleci.com/pipelines/github/pytorch/pytorch/314843/workflows/eb9c6b01-c083-4ad4-ac57-d5e4c6ef0295/jobs/13091954/steps

@imaginary-person
Copy link
Contributor

@mruberry, it's probably another CUDA 11.1 bug, as this test had passed with CUDA 10.1.

@mruberry
Copy link
Collaborator Author

mruberry commented May 3, 2021

Hey @mruberry pytorch_windows_vs2019_py36_cuda11.1_test1 starts to fail after this commit. Do you know if that failure is relevant to this PR?

https://app.circleci.com/pipelines/github/pytorch/pytorch/314843/workflows/eb9c6b01-c083-4ad4-ac57-d5e4c6ef0295/jobs/13091954/steps

Definitely related!

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 6bc3ad2.

@imaginary-person
Copy link
Contributor

That bug isn't present in CUDA 11.3, which would be added to CI soon (#56721). Didn't test with CUDA 11.2, though.

krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
Add cross OpInfo (pytorch#55483)
6d7e6ef 
Summary:
One of the tasks in pytorch#54261.

Pull Request resolved: pytorch#55483

Reviewed By: ngimel

Differential Revision: D28143091

Pulled By: mruberry

fbshipit-source-id: 0b98226a1811f61cb90d2248dd4425135a096551
@mruberry mruberry reopened this May 23, 2021
@mruberry mruberry closed this Jun 6, 2021
@mruberry mruberry deleted the cross_opinfo branch January 14, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anjali411 anjali411 anjali411 approved these changes

Assignees

No one assigned

Labels

cla signed hackathon Merged Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mruberry @facebook-github-bot @imaginary-person @mrshenli @anjali411