Skip to content

Conversation

nikithamalgifb
Copy link
Contributor

@nikithamalgifb nikithamalgifb commented Apr 7, 2021

Stack from ghstack:

@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue cla signed labels Apr 7, 2021
nikithamalgifb pushed a commit that referenced this pull request Apr 7, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2021

💊 CI failures summary and remediations

As of commit 7759cc6 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@nikithamalgifb nikithamalgifb requested a review from walterddr April 7, 2021 18:42
@nikithamalgifb nikithamalgifb changed the title Move tests related to containers in typing to test_typing.py [Hackathon]Move tests related to containers in typing to test_typing.py Apr 7, 2021
Copy link
Contributor

@walterddr walterddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. please fix flake8

nikithamalgifb pushed a commit that referenced this pull request Apr 8, 2021
@facebook-github-bot
Copy link
Contributor

@nikithamalgifb merged this pull request in c998f35.

@facebook-github-bot facebook-github-bot deleted the gh/nikithamalgifb/37/head branch April 12, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed hackathon Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants