Fixed some Clang-Tidy checks in Aten Context class #55942
Conversation
|
Hi @humanzer0! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
💊 CI failures summary and remediationsAs of commit 205ac6d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #55942 +/- ##
==========================================
- Coverage 77.14% 77.13% -0.01%
==========================================
Files 1909 1909
Lines 189091 189091
==========================================
- Hits 145865 145856 -9
- Misses 43226 43235 +9 |
jbschlosser
added
the
triaged
|
@bdhirsh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Clang-Tidy displayed that it's possible to make some methods static and const in Context class. So I made. It also shows that it has some unused headers from standard libraries included, which i will fix with a next PR. Pull Request resolved: pytorch#55942 Reviewed By: mruberry Differential Revision: D27766213 Pulled By: bdhirsh fbshipit-source-id: 4bd9b92c0b8e5c540ac94fbd2bdace64949946e3
5 participants
Clang-Tidy displayed that it's possible to make some methods static and const in Context class. So I made.
It also shows that it has some unused headers from standard libraries included, which i will fix with a next PR.