-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[PyTorch Edge] Move torch::jit::mobile::_export_operator_list() from serialization/export_module.cpp to mobile/import.cpp #56044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…serialization/export_module.cpp to mobile/import.cpp We want to be able to drop the dependence of full-jit deps in the auto-generated unit tests for 2 reasons: 1. Running bloaty on the auto-generated unit tests should be somewhat representative of the actual size. 2. The runtime environment of the auto-generated unit tests should be as close to the production environment as possible to ensure that we are running the tests in a production-like runtime. Due to the dependece on full-jit, we aren't there yet. For the auto-generated tests, we probably don't need to depend on `_export_operator_list()` evetually, but for now we do since it is used to decide whether the model being run is a Metal GPU model or a CPU model, and gates whether the test runs that model or not. Eventually, we can stop doing this in the test and do it in the codegen from PTM-CLI instead (by fetching the operators from that tool, and writing out to the BUCK file which backend(s) this model is targeting). However, that will take some time to land, so in the spirit of expediency, this change is being proposed. Discussed this offline with @myuan Differential Revision: [D27694781](https://our.internmc.facebook.com/intern/diff/D27694781/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27694781/)! [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 42d1bf6 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
dhruvbird
added a commit
that referenced
this pull request
Apr 14, 2021
…serialization/export_module.cpp to mobile/import.cpp We want to be able to drop the dependence of full-jit deps in the auto-generated unit tests for 2 reasons: 1. Running bloaty on the auto-generated unit tests should be somewhat representative of the actual size. 2. The runtime environment of the auto-generated unit tests should be as close to the production environment as possible to ensure that we are running the tests in a production-like runtime. Due to the dependece on full-jit, we aren't there yet. For the auto-generated tests, we probably don't need to depend on `_export_operator_list()` evetually, but for now we do since it is used to decide whether the model being run is a Metal GPU model or a CPU model, and gates whether the test runs that model or not. Eventually, we can stop doing this in the test and do it in the codegen from PTM-CLI instead (by fetching the operators from that tool, and writing out to the BUCK file which backend(s) this model is targeting). However, that will take some time to land, so in the spirit of expediency, this change is being proposed. Discussed this offline with @myuan Differential Revision: [D27694781](https://our.internmc.facebook.com/intern/diff/D27694781/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27694781/)! ghstack-source-id: 126529184 Pull Request resolved: #56044
…ist() from serialization/export_module.cpp to mobile/import.cpp" We want to be able to drop the dependence of full-jit deps in the auto-generated unit tests for 2 reasons: 1. Running bloaty on the auto-generated unit tests should be somewhat representative of the actual size. 2. The runtime environment of the auto-generated unit tests should be as close to the production environment as possible to ensure that we are running the tests in a production-like runtime. Due to the dependece on full-jit, we aren't there yet. For the auto-generated tests, we probably don't need to depend on `_export_operator_list()` evetually, but for now we do since it is used to decide whether the model being run is a Metal GPU model or a CPU model, and gates whether the test runs that model or not. Eventually, we can stop doing this in the test and do it in the codegen from PTM-CLI instead (by fetching the operators from that tool, and writing out to the BUCK file which backend(s) this model is targeting). However, that will take some time to land, so in the spirit of expediency, this change is being proposed. Discussed this offline with @myuan Differential Revision: [D27694781](https://our.internmc.facebook.com/intern/diff/D27694781/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27694781/)! [ghstack-poisoned]
dhruvbird
added a commit
that referenced
this pull request
Apr 15, 2021
…serialization/export_module.cpp to mobile/import.cpp Pull Request resolved: #56044 We want to be able to drop the dependence of full-jit deps in the auto-generated unit tests for 2 reasons: 1. Running bloaty on the auto-generated unit tests should be somewhat representative of the actual size. 2. The runtime environment of the auto-generated unit tests should be as close to the production environment as possible to ensure that we are running the tests in a production-like runtime. Due to the dependece on full-jit, we aren't there yet. For the auto-generated tests, we probably don't need to depend on `_export_operator_list()` evetually, but for now we do since it is used to decide whether the model being run is a Metal GPU model or a CPU model, and gates whether the test runs that model or not. Eventually, we can stop doing this in the test and do it in the codegen from PTM-CLI instead (by fetching the operators from that tool, and writing out to the BUCK file which backend(s) this model is targeting). However, that will take some time to land, so in the spirit of expediency, this change is being proposed. Discussed this offline with @myuan ghstack-source-id: 126656877 Differential Revision: [D27694781](https://our.internmc.facebook.com/intern/diff/D27694781/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27694781/)!
This pull request has been merged in bd3c63a. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
…serialization/export_module.cpp to mobile/import.cpp (pytorch#56044) Summary: Pull Request resolved: pytorch#56044 We want to be able to drop the dependence of full-jit deps in the auto-generated unit tests for 2 reasons: 1. Running bloaty on the auto-generated unit tests should be somewhat representative of the actual size. 2. The runtime environment of the auto-generated unit tests should be as close to the production environment as possible to ensure that we are running the tests in a production-like runtime. Due to the dependece on full-jit, we aren't there yet. For the auto-generated tests, we probably don't need to depend on `_export_operator_list()` evetually, but for now we do since it is used to decide whether the model being run is a Metal GPU model or a CPU model, and gates whether the test runs that model or not. Eventually, we can stop doing this in the test and do it in the codegen from PTM-CLI instead (by fetching the operators from that tool, and writing out to the BUCK file which backend(s) this model is targeting). However, that will take some time to land, so in the spirit of expediency, this change is being proposed. Discussed this offline with iseeyuan ghstack-source-id: 126656877 Test Plan: Build + BSB. Reviewed By: iseeyuan Differential Revision: D27694781 fbshipit-source-id: f31a2dfd40803c02f4fd19c45a3cc6fb9bdf9697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We want to be able to drop the dependence of full-jit deps in the auto-generated unit tests for 2 reasons:
Due to the dependece on full-jit, we aren't there yet. For the auto-generated tests, we probably don't need to depend on
_export_operator_list()
evetually, but for now we do since it is used to decide whether the model being run is a Metal GPU model or a CPU model, and gates whether the test runs that model or not.Eventually, we can stop doing this in the test and do it in the codegen from PTM-CLI instead (by fetching the operators from that tool, and writing out to the BUCK file which backend(s) this model is targeting). However, that will take some time to land, so in the spirit of expediency, this change is being proposed.
Discussed this offline with @myuan
Differential Revision: D27694781
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!