[nnc] Separate printing of optimized llvm bitcode from assembly #56117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was debugging an issue during instruction selection and wanted to see the input bitcode. This way we always print it before going into the asm generation pass. Differential Revision: [D27781683](https://our.internmc.facebook.com/intern/diff/D27781683/) [ghstack-poisoned]
facebook-github-bot
added
cla signed
oncall: jit
💊 CI failures summary and remediationsAs of commit 0f47622 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Apr 15, 2021
ZolotukhinM
approved these changes
Apr 15, 2021
| asmBuffer.set_size(0); | ||
| module_->print(asmStream, nullptr); | ||
| llvmCode = asmStream.str().str(); | ||
| GRAPH_DEBUG( |
There was a problem hiding this comment.
Maybe make one of them GRAPH_UPDATE to reduce amount of info dumped at once?
…embly" I was debugging an issue during instruction selection and wanted to see the input bitcode. This way we always print it before going into the asm generation pass. Differential Revision: [D27781683](https://our.internmc.facebook.com/intern/diff/D27781683/) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/bertmaher/104/base #56117 +/- ##
=========================================================
- Coverage 77.07% 77.07% -0.01%
=========================================================
Files 1913 1913
Lines 189643 189644 +1
=========================================================
- Hits 146174 146168 -6
- Misses 43469 43476 +7 |
|
This pull request has been merged in d56f451. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
…rch#56117) Summary: Pull Request resolved: pytorch#56117 I was debugging an issue during instruction selection and wanted to see the input bitcode. This way we always print it before going into the asm generation pass. ghstack-source-id: 126592596 Test Plan: Run with `PYTORCH_JIT_LOG_LEVEL=">>llvm_codegen"` Reviewed By: huiguoo Differential Revision: D27781683 fbshipit-source-id: 84635d0ca2a1318ae7a9a73cc1d2df450d8b6a08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
I was debugging an issue during instruction selection and wanted to
see the input bitcode. This way we always print it before going into the asm
generation pass.
Differential Revision: D27781683