-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[optim] take kw-only argument for functional optim APIs #56185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Differential Revision: [D27802169](https://our.internmc.facebook.com/intern/diff/D27802169/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27802169/)! [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 2395b11 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! that helps a lot to ensure there is no mismatch in the argument names!
Differential Revision: [D27802169](https://our.internmc.facebook.com/intern/diff/D27802169/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27802169/)! [ghstack-poisoned]
Pull Request resolved: #56185 ghstack-source-id: 126670123 Differential Revision: [D27802169](https://our.internmc.facebook.com/intern/diff/D27802169/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D27802169/)!
|
This pull request has been merged in 4611387. |
Summary: Pull Request resolved: pytorch#56185 ghstack-source-id: 126670123 Reviewed By: albanD Differential Revision: D27802169 fbshipit-source-id: f5e1cb2046dcdeecf5f6b0f70892828bf0adb22f
Stack from ghstack:
Differential Revision: D27802169
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!