Skip to content

ci-all test #56219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ci-all test #56219

wants to merge 1 commit into from

Conversation

H-Huang
Copy link
Member

@H-Huang H-Huang commented Apr 16, 2021

@facebook-github-bot facebook-github-bot added cla signed oncall: distributed Add this issue/PR to distributed oncall triage queue labels Apr 16, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 16, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 7293d72 (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

1 failure not recognized by patterns:

Job Step Action
CircleCI binary_linux_libtorch_3_7m_cpu_devtoolset7_shared-with-deps_build Build 🔁 rerun

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@H-Huang H-Huang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 16, 2021
@H-Huang H-Huang force-pushed the ci-all/h-huang branch 2 times, most recently from cd0b950 to 968c557 Compare April 16, 2021 16:30
@H-Huang H-Huang mentioned this pull request Apr 16, 2021
Closed
H-Huang added a commit that referenced this pull request Apr 16, 2021
@H-Huang
Update on "[Reland] TCPStore add watchKey method and new listener thr…
5372d3f 
…ead"


Reland of #54264

Changes:
- Update socket send() to use flag MSG_NOSIGNAL to prevent SIGPIPE because error in return is already capturad
- Update watchKey to block until callback has been registered on master.
- Fix race condition in testWatchKeyCallback which caused flaky test failures.

Test:
Ran TCPStoreTest 100 times locally with no errors, running [ci-all tests](#56219)

Differential Revision: [D27824802](https://our.internmc.facebook.com/intern/diff/D27824802)

[ghstack-poisoned]
H-Huang added a commit that referenced this pull request Apr 17, 2021
@H-Huang
Update on "TCPStore add watchKey method and new listener thread"
9b14032 
Reland of #54264

Changes:
- Update socket send() to use flag MSG_NOSIGNAL to prevent SIGPIPE because error in return is already capturad
- Update watchKey() to block until callback has been registered on master.
- Fix race condition in testWatchKeyCallback which caused flaky test failures.

Test:
Ran TCPStoreTest 100 times locally with no errors, running [ci-all tests](#56219)

Differential Revision: [D27824802](https://our.internmc.facebook.com/intern/diff/D27824802)

[ghstack-poisoned]
@codecov
Copy link

codecov bot commented Apr 17, 2021 •
edited
Loading

Codecov Report

Merging #56219 (881e0ef) into master (f9b3dcb) will decrease coverage by 8.40%.
The diff coverage is 61.11%.

❗ Current head 881e0ef differs from pull request most recent head 47f633b. Consider uploading reports for the commit 47f633b to get more accurate results

@@            Coverage Diff             @@
##           master   #56219      +/-   ##
==========================================
- Coverage   77.05%   68.65%   -8.41%     
==========================================
  Files        1916     1894      -22     
  Lines      190120   187490    -2630     
==========================================
- Hits       146501   128725   -17776     
- Misses      43619    58765   +15146

H-Huang added a commit that referenced this pull request Apr 19, 2021
@H-Huang
Update on "TCPStore add watchKey method and new listener thread"
bf1b9be 
Reland of #54264

Changes:
- Update utils sendBytes() to include flag MSG_NOSIGNAL to prevent SIGPIPE because error in return is already captured
- Update watchKey() to block until callback has also been registered on master.
- Fix race condition in testWatchKeyCallback which caused flaky test failures.

Test:
Ran build/bin/TCPStoreTest 100 times locally with no errors, ran [ci-all tests](#56219) (passed all)

Differential Revision: [D27824802](https://our.internmc.facebook.com/intern/diff/D27824802)

[ghstack-poisoned]
H-Huang added a commit that referenced this pull request Apr 21, 2021
@H-Huang
Update on "TCPStore add watchKey method and new listener thread"
531dd0a 
Reland of #54264

Changes:
- Update utils sendBytes() to include flag MSG_NOSIGNAL to prevent SIGPIPE because error in return is already captured
- Update watchKey() to block until callback has also been registered on master.
- Fix race condition in testWatchKeyCallback which caused flaky test failures.

Test:
Ran build/bin/TCPStoreTest 100 times locally with no errors, ran [ci-all tests](#56219) (passed all)

Differential Revision: [D27824802](https://our.internmc.facebook.com/intern/diff/D27824802)

[ghstack-poisoned]
H-Huang added a commit that referenced this pull request Apr 22, 2021
@H-Huang
Update on "TCPStore add watchKey method and new listener thread"
07bfee2 
Reland of #54264

Changes:
- Update utils sendBytes() to include flag MSG_NOSIGNAL to prevent SIGPIPE because error in return is already captured
- Update watchKey() to block until callback has also been registered on master.
- Fix race condition in testWatchKeyCallback which caused flaky test failures.

Test:
Ran build/bin/TCPStoreTest 100 times locally with no errors, ran [ci-all tests](#56219) (passed all)

Differential Revision: [D27824802](https://our.internmc.facebook.com/intern/diff/D27824802)

[ghstack-poisoned]
H-Huang added a commit that referenced this pull request Apr 23, 2021
@H-Huang
Update on "TCPStore add watchKey method and new listener thread"
e31dd03 
Reland of #54264

Changes:
- Update utils sendBytes() to include flag MSG_NOSIGNAL to prevent SIGPIPE because error in return is already captured
- Update watchKey() to block until callback has also been registered on master.
- Fix race condition in testWatchKeyCallback which caused flaky test failures.

Test:
Ran build/bin/TCPStoreTest 100 times locally with no errors, ran [ci-all tests](#56219) (passed all)

Differential Revision: [D27824802](https://our.internmc.facebook.com/intern/diff/D27824802)

[ghstack-poisoned]
@H-Huang
TCPStore add watchKey method and new listener thread
7293d72 
ghstack-source-id: a9bacbc
Pull Request resolved: #56217
H-Huang added a commit that referenced this pull request Apr 28, 2021
@H-Huang
Update on "TCPStore add watchKey method and new listener thread"
d5b5541 
Reland of #54264

Changes:
- Update utils sendBytes() to include flag MSG_NOSIGNAL to prevent SIGPIPE because error in return is already captured
- Update watchKey() to block until callback has also been registered on master.
- Fix race condition in testWatchKeyCallback which caused flaky test failures.

Test:
Ran build/bin/TCPStoreTest 100 times locally with no errors, ran [ci-all tests](#56219) (passed all)

Differential Revision: [D27824802](https://our.internmc.facebook.com/intern/diff/D27824802)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Apr 28, 2021
@H-Huang @facebook-github-bot
[Reland] TCPStore add watchKey method and new listener thread (#56217)
5a10ee7 
Summary:
Pull Request resolved: #56217

Reland of #54264

Changes:
- Update socket send() to use flag MSG_NOSIGNAL to prevent SIGPIPE because error in return is already capturad
- Update watchKey to block until callback has been registered on master.
- Fix race condition in testWatchKeyCallback which caused flaky test failures.

Test:
Ran TCPStoreTest 100 times locally with no errors, running [ci-all tests](#56219)

Test Plan: Imported from OSS

Reviewed By: mrshenli

Differential Revision: D27824802

Pulled By: H-Huang

fbshipit-source-id: c32230ce726d7d848b9896a63aa52b8eb04a0a2d
@H-Huang H-Huang closed this Apr 29, 2021
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
@H-Huang
[Reland] TCPStore add watchKey method and new listener thread (pytorc…
317ff0b 
…h#56217)

Summary:
Pull Request resolved: pytorch#56217

Reland of pytorch#54264

Changes:
- Update socket send() to use flag MSG_NOSIGNAL to prevent SIGPIPE because error in return is already capturad
- Update watchKey to block until callback has been registered on master.
- Fix race condition in testWatchKeyCallback which caused flaky test failures.

Test:
Ran TCPStoreTest 100 times locally with no errors, running [ci-all tests](pytorch#56219)

Test Plan: Imported from OSS

Reviewed By: mrshenli

Differential Revision: D27824802

Pulled By: H-Huang

fbshipit-source-id: c32230ce726d7d848b9896a63aa52b8eb04a0a2d
@github-actions github-actions bot deleted the ci-all/h-huang branch February 11, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed oncall: distributed Add this issue/PR to distributed oncall triage queue triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@H-Huang @facebook-github-bot