unified GlooStore and c10d store API (#55719) #56222
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msaroufim
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
facebook-github-bot
added
oncall: distributed
💊 CI failures summary and remediationsAs of commit e882d84 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D27785267 |
|
Kicked off a rebase in phabricator and exported it here @rohan-varma |
Summary: Pull Request resolved: pytorch#56222 Pull Request resolved: pytorch#55719 Test Plan: Imported from OSS Differential Revision: D27785267 Pulled By: msaroufim fbshipit-source-id: e95a5012688d9ff9c2b3ab74c273ea99726e62db
|
This pull request was exported from Phabricator. Differential Revision: D27785267 |
msaroufim
force-pushed
the
export-D27785267
branch
from
290a9b1 to
e882d84
Compare
rohan-varma
reviewed
Apr 16, 2021
Codecov Report
@@ Coverage Diff @@
## master #56222 +/- ##
=======================================
Coverage 77.05% 77.05%
=======================================
Files 1916 1916
Lines 190130 190130
=======================================
+ Hits 146502 146505 +3
+ Misses 43628 43625 -3 |
rohan-varma
approved these changes
Apr 18, 2021
|
Looks like I"m not authorized to merge this pull request, I'm guessing only file owners can merge? |
|
@msaroufim The usual process is actually to land the internal diff, and then it automatically syncs up with github. |
|
@msaroufim merged this pull request in 48aaea3. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#56222 Pull Request resolved: pytorch#55719 Test Plan: Imported from OSS Reviewed By: rohan-varma Differential Revision: D27785267 Pulled By: msaroufim fbshipit-source-id: ce247f9226ecc971af8e1f08adeb835f64973e12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Pull Request resolved: #55719
Test Plan: Imported from OSS
Differential Revision: D27785267
Pulled By: msaroufim