Filter out more expected errors from sccache log #56281
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 951e017 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
driazati
approved these changes
Apr 16, 2021
walterddr
approved these changes
Apr 16, 2021
It is useful to debug whether there's any issue regarding build time regression. no necessarily for a failure though |
samestep
commented
Apr 16, 2021
Co-authored-by: Rong Rong <walterddr.walterddr@gmail.com>
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: This PR extends `.jenkins/pytorch/print_sccache_log.py` to filter out a distracting "error" message that walterddr came across while debugging failures in pytorch#55176: ``` =================== sccache compilation log =================== ERROR 2021-04-05T15:44:18Z: sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function ‘int main()’:\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected ‘;’ before ‘}’ token\n int main() { return 0 }\n ^\n" } ``` Pull Request resolved: pytorch#56281 Test Plan: TODO (reviewers: is there an easy way to test this?) Reviewed By: walterddr Differential Revision: D27826064 Pulled By: samestep fbshipit-source-id: 7322a830c1246820a5b2b7bbeaa4697ebd13b617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends
.jenkins/pytorch/print_sccache_log.pyto filter out a distracting "error" message that @walterddr came across while debugging failures in #55176:Test plan:
TODO (reviewers: is there an easy way to test this?)