-
Notifications
You must be signed in to change notification settings - Fork 25.9k
Split test_testing.py::TestAsserts for multiple devices
#56365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 12192de (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. [ghstack-poisoned]
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. ghstack-source-id: af973ee Pull Request resolved: #56365
walterddr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. thanks for the prompt follow up @pmeier
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. [ghstack-poisoned]
|
This refactor PR seems unnecessary but I made some comments if we really want to pursue it as part of this stack |
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. [ghstack-poisoned]
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. [ghstack-poisoned]
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. [ghstack-poisoned]
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. [ghstack-poisoned]
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. [ghstack-poisoned]
Follow-up to pytorch#54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. ghstack-source-id: 7a8d587 Pull Request resolved: pytorch#56365
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. [ghstack-poisoned]
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. ghstack-source-id: 5af6316 Pull Request resolved: #56365
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. [ghstack-poisoned]
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. ghstack-source-id: 2e4d3c6 Pull Request resolved: #56365
mruberry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks really good, @pmeier; just a couple suggestions
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. Differential Revision: [D28247529](https://our.internmc.facebook.com/intern/diff/D28247529) [ghstack-poisoned]
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. ghstack-source-id: 73a18c1 Pull Request resolved: #56365
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. Differential Revision: [D28247529](https://our.internmc.facebook.com/intern/diff/D28247529) [ghstack-poisoned]
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. ghstack-source-id: de422d7 Pull Request resolved: #56365
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. Differential Revision: [D28247529](https://our.internmc.facebook.com/intern/diff/D28247529) [ghstack-poisoned]
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. ghstack-source-id: 8bffc66 Pull Request resolved: #56365
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. Differential Revision: [D28247529](https://our.internmc.facebook.com/intern/diff/D28247529) [ghstack-poisoned]
Follow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with `@onlyCPU`, this factors out all tests that actually need another device into a separate test case. ghstack-source-id: 61af033 Pull Request resolved: #56365
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
) Summary: Pull Request resolved: pytorch#56365 Follow-up to pytorch#54784 (comment). Instead of having one large testcase where most methods are decorated with `onlyCPU`, this factors out all tests that actually need another device into a separate test case. Test Plan: Imported from OSS Reviewed By: walterddr, albanD Differential Revision: D28247529 Pulled By: mruberry fbshipit-source-id: 946e7694b70e736941565f29b5dd459ed7fbca4e
Stack from ghstack:
test_testing.py::TestAssertsfor multiple devices #56365 Splittest_testing.py::TestAssertsfor multiple devicesFollow-up to #54784 (comment). Instead of having one large testcase where most methods are decorated with
@onlyCPU, this factors out all tests that actually need another device into a separate test case.Differential Revision: D28247529