.github: Build test binaries in build/ directory #56941
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets the custom test binaries we build in .jenkins/pytorch/build.sh to be built in the `build` directory instead of the directory above the workspace. This should alleviate any weirdness we were seeing before with test binaries having to be overwritten Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 46220e9 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Sets the custom test binaries we build in .jenkins/pytorch/build.sh to be built in the `build` directory instead of the directory above the workspace. This should alleviate any weirdness we were seeing before with test binaries having to be overwritten Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
Sets the custom test binaries we build in .jenkins/pytorch/build.sh to be built in the `build` directory instead of the directory above the workspace. This should alleviate any weirdness we were seeing before with test binaries having to be overwritten Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
Sets the custom test binaries we build in .jenkins/pytorch/build.sh to be built in the `build` directory instead of the directory above the workspace. This should alleviate any weirdness we were seeing before with test binaries having to be overwritten Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
walterddr
approved these changes
Apr 26, 2021
walterddr
reviewed
Apr 26, 2021
.jenkins/pytorch/test.sh
Outdated
| COMPACT_JOB_NAME="${BUILD_ENVIRONMENT}" | ||
|
|
||
| # Get fully qualified path using realpath | ||
| CUSTOM_TEST_ARTIFACT_BUILD_DIR=$(realpath ${CUSTOM_TEST_ARTIFACT_BUILD_DIR:-${PWD}/../}) |
There was a problem hiding this comment.
nit: why do we need this default back to ${PWD}/../ behavior? can we remove it entirely?
There was a problem hiding this comment.
I wanted to keep them so that the circleci builds don't actually change their current behavior.
Trying to make the least obstructive change here.
walterddr
reviewed
Apr 26, 2021
| cp build/.ninja_log dist | ||
| fi | ||
|
|
||
| CUSTOM_TEST_ARTIFACT_BUILD_DIR=${CUSTOM_TEST_ARTIFACT_BUILD_DIR:-${PWD}/../} |
Sets the custom test binaries we build in .jenkins/pytorch/build.sh to be built in the `build` directory instead of the directory above the workspace. This should alleviate any weirdness we were seeing before with test binaries having to be overwritten Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
|
@seemethere merged this pull request in e138987. |
crcrpar
pushed a commit
to crcrpar/pytorch
that referenced
this pull request
May 7, 2021
Summary: Pull Request resolved: pytorch#56941 Sets the custom test binaries we build in .jenkins/pytorch/build.sh to be built in the `build` directory instead of the directory above the workspace. This should alleviate any weirdness we were seeing before with test binaries having to be overwritten Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Test Plan: Imported from OSS Reviewed By: H-Huang Differential Revision: D28018453 Pulled By: seemethere fbshipit-source-id: 74add11037a622e011d00fb6292bfe20e1d55d9e
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#56941 Sets the custom test binaries we build in .jenkins/pytorch/build.sh to be built in the `build` directory instead of the directory above the workspace. This should alleviate any weirdness we were seeing before with test binaries having to be overwritten Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Test Plan: Imported from OSS Reviewed By: H-Huang Differential Revision: D28018453 Pulled By: seemethere fbshipit-source-id: 74add11037a622e011d00fb6292bfe20e1d55d9e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Sets the custom test binaries we build in .jenkins/pytorch/build.sh to
be built in the
builddirectory instead of the directory above theworkspace.
This should alleviate any weirdness we were seeing before with test
binaries having to be overwritten
Signed-off-by: Eli Uriegas eliuriegas@fb.com
Differential Revision: D28018453