[jit] Add a utility class SourceRef to represent Source as keys #57396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: A new type SourceRef is introduced to represent a unique identifier to source text. The type holds refcount to underlying source, and supports comparators and hash functions, such that it can be used in C++ and Python maps. In later diffs we will use this to aggregate and print profiling information. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit cb58b6b (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: jit
This was referenced Apr 30, 2021
… keys" Summary: A new type SourceRef is introduced to represent a unique identifier to source text. The type holds refcount to underlying source, and supports comparators and hash functions, such that it can be used in C++ and Python maps. In later diffs we will use this to aggregate and print profiling information. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
gmagogsfm
approved these changes
May 1, 2021
…esent Source as keys" Summary: A new type SourceRef is introduced to represent a unique identifier to source text. The type holds refcount to underlying source, and supports comparators and hash functions, such that it can be used in C++ and Python maps. In later diffs we will use this to aggregate and print profiling information. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28133578](https://our.internmc.facebook.com/intern/diff/D28133578) [ghstack-poisoned]
|
@zhxchen17 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…eys" Summary: A new type SourceRef is introduced to represent a unique identifier to source text. The type holds refcount to underlying source, and supports comparators and hash functions, such that it can be used in C++ and Python maps. In later diffs we will use this to aggregate and print profiling information. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28133578](https://our.internmc.facebook.com/intern/diff/D28133578) [ghstack-poisoned]
|
@zhxchen17 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
… keys" Summary: A new type SourceRef is introduced to represent a unique identifier to source text. The type holds refcount to underlying source, and supports comparators and hash functions, such that it can be used in C++ and Python maps. In later diffs we will use this to aggregate and print profiling information. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28133578](https://our.internmc.facebook.com/intern/diff/D28133578) [ghstack-poisoned]
|
@zhxchen17 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
… keys" Summary: A new type SourceRef is introduced to represent a unique identifier to source text. The type holds refcount to underlying source, and supports comparators and hash functions, such that it can be used in C++ and Python maps. In later diffs we will use this to aggregate and print profiling information. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28133578](https://our.internmc.facebook.com/intern/diff/D28133578) [ghstack-poisoned]
… keys" Summary: A new type SourceRef is introduced to represent a unique identifier to source text. The type holds refcount to underlying source, and supports comparators and hash functions, such that it can be used in C++ and Python maps. In later diffs we will use this to aggregate and print profiling information. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28133578](https://our.internmc.facebook.com/intern/diff/D28133578) [ghstack-poisoned]
|
@zhxchen17 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
… keys" Summary: A new type SourceRef is introduced to represent a unique identifier to source text. The type holds refcount to underlying source, and supports comparators and hash functions, such that it can be used in C++ and Python maps. In later diffs we will use this to aggregate and print profiling information. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D28133578](https://our.internmc.facebook.com/intern/diff/D28133578) [ghstack-poisoned]
|
@zhxchen17 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 3a3959d. |
jasperzhong
pushed a commit
to jasperzhong/swift
that referenced
this pull request
Nov 25, 2021
Summary: A new type SourceRef is introduced to represent a unique identifier to source text. The type holds refcount to underlying source, and supports comparators and hash functions, such that it can be used in C++ and Python maps. In later diffs we will use this to aggregate and print profiling information. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: b176621 Pull Request resolved: pytorch/pytorch#57396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
A new type SourceRef is introduced to represent a unique identifier to source
text. The type holds refcount to underlying source, and supports comparators
and hash functions, such that it can be used in C++ and Python maps. In later
diffs we will use this to aggregate and print profiling information.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D28133578