Skip to content

Conversation

@wconstab
Copy link
Contributor

@wconstab wconstab commented May 3, 2021

Summary: To be used by PyTorchPredictor integration for deploy.

Test Plan: tested via new unit tests

Differential Revision: D28154522

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 3, 2021

💊 CI failures summary and remediations

As of commit cbe2454 (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_macos_10_13_py3_build (1/1)

Step: "Spin up environment" (full log | diagnosis details | 🔁 rerun)

Waiting for a VM assignment: .......................................................................
Build-agent version 1.0.59410-ac2f4da3 (2021-05-04T13:51:31+0000)
Creating a dedicated VM with xcode:12.0 image
Waiting for a VM assignment: ............................................................................................................................................................................................................................................................................................................

We timed out preparing a VM for this build, potentially due to our infrastructure or cloud provider.  Please retry the build in a few minutes

Unexpected capacity error: error caused by capacity


1 failure not recognized by patterns:

Job Step Action
GitHub Actions render_test_results Output Test Results (Click Me) 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D28154522

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D28154522

@wconstab wconstab force-pushed the export-D28154522 branch from 53878b1 to 93de38c Compare May 3, 2021 20:10
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D28154522

@wconstab wconstab force-pushed the export-D28154522 branch from 93de38c to aa5d188 Compare May 4, 2021 16:11
)

Summary:
Pull Request resolved: pytorch#57484

To be used by PyTorchPredictor integration for deploy.

Test Plan: tested via new unit tests

Differential Revision: D28154522

fbshipit-source-id: 795bd1277fe3d475b9fd03c6181f040bfd0f822e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D28154522

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ba500c5.

@mruberry
Copy link
Collaborator

mruberry commented May 6, 2021

Bad news, @wconstab, this appears to be breaking three HUD builds, sample snippet:

/var/lib/jenkins/workspace/torch/csrc/deploy/interpreter/interpreter_impl.cpp: In member function 'virtual torch::deploy::Obj ConcreteInterpreterSessionImpl::call_kwargs(torch::deploy::Obj, std::vector<c10::IValue>, std::unordered_map<std::__cxx11::basic_string<char>, c10::IValue>)':
/var/lib/jenkins/workspace/torch/csrc/deploy/interpreter/interpreter_impl.cpp:440:15: error: decomposition declaration only available with -std=c++1z or -std=gnu++1z [-Werror]
     for (auto [key, value] : kwargs) {

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 40cb55f.

krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
)

Summary:
Pull Request resolved: pytorch#57484

To be used by PyTorchPredictor integration for deploy.

Test Plan: tested via new unit tests

Reviewed By: suo

Differential Revision: D28154522

fbshipit-source-id: 5ba57a8d7f01686180e6fd47663635ec3ab2120d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants