Switch GHA test stats S3 upload token #58156
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit d748c35 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Codecov Report
@@ Coverage Diff @@
## master #58156 +/- ##
==========================================
- Coverage 76.84% 76.84% -0.01%
==========================================
Files 1986 1986
Lines 197902 197902
==========================================
- Hits 152079 152074 -5
- Misses 45823 45828 +5 |
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
janeyx99
approved these changes
May 12, 2021
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: TODOs: - [x] generate a temporary new token on this repo for testing purposes - [x] change the name of the S3 secret used in the workflow YAML definitions - [x] check the test plan - [x] replace the temporary token with a more permanent one - [x] check the test plan again - [x] uncomment the `if` statement that guards against uploading PR test stats Pull Request resolved: pytorch#58156 Test Plan: Check the [ossci-metrics bucket](https://s3.console.aws.amazon.com/s3/buckets/ossci-metrics) after CI runs on this PR. Specifically, [this prefix](https://s3.console.aws.amazon.com/s3/buckets/ossci-metrics?region=us-east-1&prefix=test_time/a3445bfbd7efc602c28f5146fb562aa35ec50077/pytorch-linux-xenial-py3.6-gcc5.4/&showversions=false) has two objects under it. Reviewed By: janeyx99 Differential Revision: D28393138 Pulled By: samestep fbshipit-source-id: 2c39c102652d471afa016cfc4942bb1e5bbb4163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs:
ifstatement that guards against uploading PR test statsTest plan:
Check the ossci-metrics bucket after CI runs on this PR. Specifically, this prefix has two objects under it.